snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
ClosedPublic
Actions

Authored by christos on Oct 16 2024, 1:42 PM.

Details

Reviewers

markj
emaste

Commits

rG867b2ee99995: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
rGde009cf68ba6: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries

Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Oct 16 2024, 1:42 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 16 2024, 1:42 PM

christos requested review of this revision.Oct 16 2024, 1:42 PM

Harbormaster completed remote builds in B60036: Diff 144987.Oct 16 2024, 1:42 PM

markj accepted this revision.Oct 16 2024, 1:46 PM

This revision is now accepted and ready to land.Oct 16 2024, 1:46 PM

This is fine with me. There doesn't seem to be a consistent ordering here so it's not clear to me which one of the two is the "right" one to keep. It also looks like there are some additional duplicates.

sys/dev/sound/pci/hda/hdac.h
97–98	is this one also duplicated?

christos retitled this revision from snd_hda: Remove duplicate HDA_INTEL_CMLKLP entry to snd_hda: Remove duplicate HDA_INTEL_CMLK* entries.Oct 16 2024, 8:58 PM