linker: Handle a truncated hints file properly
ClosedPublic
Actions

Authored by markj on Oct 22 2024, 3:05 PM.

Details

Reviewers

imp
christos

Commits

rG9e3e111d749a: linker: Handle a truncated hints file properly
rGd57d71423847: linker: Handle a truncated hints file properly
rGb5149b265346: linker: Handle a truncated hints file properly

Summary

If vattr.va_size is 0, we will end up accessing invalid memory. This is
mostly harmless (because malloc(0) still allocates some memory), but it
triggers a KASAN report.

PR: 282268

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 22 2024, 3:05 PM

Herald added subscribers: olce, imp. · View Herald TranscriptOct 22 2024, 3:05 PM

markj requested review of this revision.Oct 22 2024, 3:05 PM

Harbormaster completed remote builds in B60151: Diff 145352.Oct 22 2024, 3:05 PM

imp accepted this revision.Oct 22 2024, 3:16 PM

This revision is now accepted and ready to land.Oct 22 2024, 3:16 PM

Tested on my VM.

Closed by commit rGb5149b265346: linker: Handle a truncated hints file properly (authored by markj). · Explain WhyOct 23 2024, 10:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGb5149b265346: linker: Handle a truncated hints file properly.

markj added a commit: rGd57d71423847: linker: Handle a truncated hints file properly.Oct 30 2024, 1:22 PM

markj added a commit: rG9e3e111d749a: linker: Handle a truncated hints file properly.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_linker.c

4 lines

Diff 145403

View Options

linker: Handle a truncated hints file properlyClosedPublicActions