onyx: Remove unreachable if condition
ClosedPublic
Actions

Authored by christos on Oct 17 2024, 2:41 PM.

Details

Reviewers

markj
emaste
andreast

Commits

rGe609dfa98fd3: onyx: Remove unreachable if condition
rG6f96ef84b359: onyx: Remove unreachable if condition

Summary

Both conditions are the same, so the second one is unreachable.

PR: 229550
Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Oct 17 2024, 2:41 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2024, 2:41 PM

christos requested review of this revision.Oct 17 2024, 2:41 PM

Harbormaster completed remote builds in B60059: Diff 145042.Oct 17 2024, 2:41 PM

I think this was probably the intent, yes.

This revision is now accepted and ready to land.Oct 17 2024, 3:11 PM

emaste added a reviewer: andreast.Oct 17 2024, 3:31 PM

Seems like a strange error to make and this is a functional change because the code in the else if block is dead today. I added @andreast as the committer of 9c3fbfbd6a739b053611d35ead0a67a5ecba8825 but I wouldn't be surprised if this hardware is not functional any longer.

I don't object to landing this though - if someone reports that the driver no longer probes we can get them to investigate.

Fine with me. I'm pretty sure, no machine with this chip will run an actual FreeBSD. Speaking for me, I have given up Mac PowerPC and FreeBSD a long time ago.

Closed by commit rG6f96ef84b359: onyx: Remove unreachable if condition (authored by christos). · Explain WhyOct 18 2024, 8:51 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG6f96ef84b359: onyx: Remove unreachable if condition.

christos added a commit: rGe609dfa98fd3: onyx: Remove unreachable if condition.Oct 20 2024, 11:22 AM