Page MenuHomeFreeBSD

onyx: Remove unreachable if condition
ClosedPublic

Authored by christos on Oct 17 2024, 2:41 PM.
Tags
None
Referenced Files
F104631828: D47167.diff
Sun, Dec 8, 11:46 AM
Unknown Object (File)
Thu, Nov 28, 5:10 PM
Unknown Object (File)
Fri, Nov 22, 10:11 PM
Unknown Object (File)
Tue, Nov 12, 8:49 AM
Unknown Object (File)
Oct 31 2024, 8:27 PM
Unknown Object (File)
Oct 29 2024, 7:57 AM
Unknown Object (File)
Oct 28 2024, 4:10 PM
Unknown Object (File)
Oct 22 2024, 5:47 PM
Subscribers

Details

Summary

Both conditions are the same, so the second one is unreachable.

PR: 229550
Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this was probably the intent, yes.

This revision is now accepted and ready to land.Oct 17 2024, 3:11 PM

Seems like a strange error to make and this is a functional change because the code in the else if block is dead today. I added @andreast as the committer of 9c3fbfbd6a739b053611d35ead0a67a5ecba8825 but I wouldn't be surprised if this hardware is not functional any longer.

I don't object to landing this though - if someone reports that the driver no longer probes we can get them to investigate.

Fine with me. I'm pretty sure, no machine with this chip will run an actual FreeBSD. Speaking for me, I have given up Mac PowerPC and FreeBSD a long time ago.

This revision was automatically updated to reflect the committed changes.