Added @crees as a reviewer, since line 38 of this script lists him as the current maintainer of the script.

The entry in “sysutils/Makefile” is missing from this diff (sorry if this is stating the obvious)

Abandoning this revision, in favour of Ed’s recommendation to push 8.1p1, 8.2p1, 8.3p1, 8.4p1 in order.

Hi @bcran,
I have accepted this revision - giving you my approval to commit this to ports.
Please note that I have requested 4 changes to be made before you do (not necessary to re-submit for review).
The MOVED entry in particular is mandatory.
Thanks for all your work!
-@woodsb02

The reason I raised this request was I noticed a new feature was not yet available in the FreeBSD 13 source:

• sshd(8): add an Include sshd_config keyword that allows including additional configuration files via glob(3) patterns. bz2468

Note that I do not have my src commit bit (I am a ports committer), so I am seeking approval to push this src commit upstream to the vendor/openssh branch.

Ping - This review can be closed now, since sysutils/zrepl has been in ports for some time. :)

Hi John, looks ok to me. Can I leave it to you to commit this one?

Given it’s a long standing pkg bug, I doubt it will be resolved soon even with your test pkg repo which helps reproduce it.

Thanks - looks good to me now. My approval isn't required in any way, but I have marked this review as accepted by me to show that I have reviewed and concur that it looks ready to land.

Thanks very much for your work on bringing Xfce 4.16 to the ports tree @madpilot!

Apologies for being absent recently - life took over... but I’ll have some time to look at this again between Xmas and New Year.

Hi Rebecca, looking good.
I've had a go at clarifying the "summary" about to match what the commit text would be. Can you please have a look and improve it if you can?
I have added in a few comments inline below - can you please have a look?
Cheers,
Ben

ping @ler
Sorry to probe, just checking if you had any comments on this patch to update the 1password CLI client?

Overcome by events - the port was updated to 1.9.0 in FreeBSD ports commit r542002
http://svnweb.freebsd.org/changeset/ports/542002

Thanks for this Guido.
LGTM!

In D25139#553963, @debdrup wrote:

I wonder if it would be appropriate to ask @woodsb02 whether his instructions on https://wiki.freebsd.org/BenWoods/DebuggingPorts could be added as a section of this handbook page, or perhaps a note made about it instructing the user to look at the wiki? It seems very appropriate, as otherwise, people might not know how to get debugging symbols for third party programs supplied by ports.

ping - sorry to hassle Sofian, any thoughts on this diff?

I just spun up a few other operating systems to check their /root/ directory permissions, and found the following:

Typically there are 2 main options to fix the “sed -i” issue:

1. Add post-patch: target to port Makefile to replace them all

Example port: math/cvc4/Makefile

post-patch:
      @${REINPLACE_CMD} -e "s|sed -i 's|sed -i '' 's|g" \
      ${WRKSRC}/src/fix-install-headers.sh