archivers/xarchiver: Update to 0.5.4.15
ClosedPublic
Actions

Authored by woodsb02 on Jun 30 2020, 4:58 PM.

Details

Reviewers

danilo

Commits

rP547171: - Update to 0.5.4.15

Summary

archivers/xarchiver: Update to 0.5.4.15

Default to using GTK-3, since Xfce now also uses GTK-3
Use GNU tar since xarchiver now uses many arguments which are unsupported in bsdtar
Ensure Info-ZIP is used instead of FreeBSD unzip, to ensure zipinfo mode output matches required format for xarchiver when listing the contents of zip files
Patch CLI calls to move option flags before file arguments

Test Plan

poudriere testport -j 13amd64 = reports ok
Runtime testing appears to work well

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

woodsb02 created this revision.Jun 30 2020, 4:58 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 30 2020, 4:58 PM

woodsb02 requested review of this revision.Jun 30 2020, 4:58 PM

Harbormaster completed remote builds in B32065: Diff 73916.Jun 30 2020, 4:58 PM

Hi Ben, thank you for that.

I'm testing your patch and it looks good. Except for gzip files. xarchiver is using the system gzip and failing to parse its output. I'll include archivers/gzip in the RUN_DEPENDS list and change the search path to ${LOCALBASE} as you did for zip files.

Thanks!

mat added inline comments.Aug 28 2020, 7:49 AM

archivers/xarchiver/Makefile
18 ↗	(On Diff #73916)	unzip is always present in PATH, so this is now a noop. You either have to specify `${LOCALBASE}/bin/unzip`, or keep `zipinfo` as it was before.