Page MenuHomeFreeBSD

Add sysutils/sd-mux-ctrl, Tizen SD mux control program
ClosedPublic

Authored by emaste on Mar 28 2021, 8:39 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.
emaste added a subscriber: gonzo.
diizzy added inline comments.
sysutils/sd-mux-ctrl/Makefile
4 ↗(On Diff #86449)

Please follow example Example 5.13 in Porters Handbook

10 ↗(On Diff #86449)
18 ↗(On Diff #86449)

Not needed

19 ↗(On Diff #86449)

You don't need to use full hash (Example 5.13 in Porters Handbook)

sysutils/sd-mux-ctrl/Makefile
18 ↗(On Diff #86449)

this is different from the portname though

19 ↗(On Diff #86449)

Full hash seems preferable though to avoid any chance of a future collision?

DISTVERSION and LICENSE_FILE as reported

Use upstream + patch, from @daniel.engberg.lists_pyret.net

Looks good! Here some guidance:

  • Using poudriere testport for pre-commit testing with poudriere testport -j <jail> -p <porttree> -o sysutils/sd-mux-ctrl
  • Using port test from pkg porttools for pre-commit testing
cd /usr/port/sysutils/sd-mux-ctrl
sudo port test
  • After approved review, you could use addport to add it to the tree with the command below. It will add the entries in the category Makefile and prompt you for confirmation
cd /path/to/svn
/usr/ports/Tools/scripts/addport -m -a -i -y -f -d sysutils/sd-mux-ctrl
This revision is now accepted and ready to land.Mar 28 2021, 9:41 PM
sbz requested changes to this revision.Mar 28 2021, 9:50 PM

You need to run again make makesum indeed since the PATCH change.

This revision now requires changes to proceed.Mar 28 2021, 9:50 PM
sysutils/sd-mux-ctrl/Makefile
20 ↗(On Diff #86454)

Need to add the extension to fetch the new distfile, i.e tar:bz2

You can read the description into /usr/ports/Mk/Uses/tar.mk

bz2 per @daniel.engberg.lists_pyret.net

This revision is now accepted and ready to land.Mar 28 2021, 10:23 PM

The entry in “sysutils/Makefile” is missing from this diff (sorry if this is stating the obvious)

The entry in “sysutils/Makefile” is missing from this diff (sorry if this is stating the obvious)

It will be added automatically with addport, cf my comment above.

D29476 submitted for an issue discovered running addport