Page MenuHomeFreeBSD
Differential D29474

Add sysutils/sd-mux-ctrl, Tizen SD mux control program
ClosedPublic
Actions

Authored by emaste on Mar 28 2021, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 10 2024, 9:40 AM
Unknown Object (File)
Jan 7 2024, 2:15 PM
Unknown Object (File)
Dec 25 2023, 4:46 AM
Unknown Object (File)
Dec 20 2023, 6:39 AM
Unknown Object (File)
Dec 4 2023, 12:31 AM
Unknown Object (File)
Nov 24 2023, 10:38 PM
Unknown Object (File)
Nov 14 2023, 8:08 AM
Unknown Object (File)
Nov 12 2023, 8:16 AM
View All 36 Files
Subscribers
diizzy
gonzo
sbz
woodsb02

Details

Reviewers
sbz
Commits
rP569418: Add sysutils/sd-mux-ctrl, Tizen SD mux control program

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 28 2021, 8:39 PM
emaste created this revision.
emaste added a subscriber: gonzo.

See also https://wiki.tizen.org/SD_MUX

diizzy added a subscriber: diizzy.Mar 28 2021, 8:47 PM
diizzy added inline comments.
sysutils/sd-mux-ctrl/Makefile
5

Please follow example Example 5.13 in Porters Handbook

11

https://docs.freebsd.org/en/books/porters-handbook/book.html#licenses-license_file-ex1

19

Not needed

20

You don't need to use full hash (Example 5.13 in Porters Handbook)

emaste added inline comments.Mar 28 2021, 9:01 PM
sysutils/sd-mux-ctrl/Makefile
19

this is different from the portname though

20

Full hash seems preferable though to avoid any chance of a future collision?

emaste updated this revision to Diff 86453.Mar 28 2021, 9:11 PM

DISTVERSION and LICENSE_FILE as reported

emaste updated this revision to Diff 86454.Mar 28 2021, 9:25 PM

Use upstream + patch, from @daniel.engberg.lists_pyret.net

sbz added a subscriber: sbz.EditedMar 28 2021, 9:26 PM

Looks good! Here some guidance:

  • Using poudriere testport for pre-commit testing with poudriere testport -j <jail> -p <porttree> -o sysutils/sd-mux-ctrl
  • Using port test from pkg porttools for pre-commit testing
cd /usr/port/sysutils/sd-mux-ctrl
sudo port test
  • After approved review, you could use addport to add it to the tree with the command below. It will add the entries in the category Makefile and prompt you for confirmation
cd /path/to/svn
/usr/ports/Tools/scripts/addport -m -a -i -y -f -d sysutils/sd-mux-ctrl
sbz accepted this revision.Mar 28 2021, 9:41 PM
This revision is now accepted and ready to land.Mar 28 2021, 9:41 PM
sbz requested changes to this revision.Mar 28 2021, 9:50 PM

You need to run again make makesum indeed since the PATCH change.

This revision now requires changes to proceed.Mar 28 2021, 9:50 PM
sbz added inline comments.Mar 28 2021, 9:58 PM
sysutils/sd-mux-ctrl/Makefile
21

Need to add the extension to fetch the new distfile, i.e tar:bz2

You can read the description into /usr/ports/Mk/Uses/tar.mk

diizzy added a comment.Mar 28 2021, 10:06 PM

https://projects.pyret.net/files/public/freebsd/0001-sdmux.patch Updated patch, sorry :/

emaste updated this revision to Diff 86457.Mar 28 2021, 10:13 PM

bz2 per @daniel.engberg.lists_pyret.net

sbz accepted this revision.Mar 28 2021, 10:23 PM
This revision is now accepted and ready to land.Mar 28 2021, 10:23 PM
woodsb02 added a subscriber: woodsb02.Mar 28 2021, 10:29 PM

The entry in “sysutils/Makefile” is missing from this diff (sorry if this is stating the obvious)

sbz added a comment.Mar 28 2021, 10:31 PM
In D29474#660248, @woodsb02 wrote:

The entry in “sysutils/Makefile” is missing from this diff (sorry if this is stating the obvious)

It will be added automatically with addport, cf my comment above.

Closed by commit rP569418: Add sysutils/sd-mux-ctrl, Tizen SD mux control program (authored by emaste). · Explain WhyMar 28 2021, 10:42 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rP569418: Add sysutils/sd-mux-ctrl, Tizen SD mux control program.
emaste added a comment.Mar 28 2021, 10:46 PM

D29476 submitted for an issue discovered running addport

emaste mentioned this in D29477: addport: do not hardcode /usr/ports for fetchindex.Mar 28 2021, 10:50 PM

Revision Contents
Changeset List

PathSize
sysutils/
sd-mux-ctrl/
24 lines
3 lines
4 lines

Diff 86453

View Options

sysutils/sd-mux-ctrl/Makefile

Loading...
View Options

sysutils/sd-mux-ctrl/distinfo

Loading...
View Options

sysutils/sd-mux-ctrl/pkg-descr

Loading...