Page MenuHomeFreeBSD
Feed Advanced Search

Feb 9 2021

donner added a comment to D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.

OTOH it's bad, because it prevents the code from running under const constraints.

Feb 9 2021, 11:38 AM
donner retitled D28546: netgraph/ng_bridge: Document staleness in multithreaded operation from netgraph/ng_bridge: Switch staleness to counter framework to netgraph/ng_bridge: Document staleness in multithreaded operation.
Feb 9 2021, 11:36 AM
donner updated the diff for D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
  • Revert "Switch staleness to counter framework."
  • Comment why it's safe to do so.
Feb 9 2021, 11:34 AM
donner added a comment to D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
In D28546#639111, @kp wrote:

I don't know if counter(9) makes sense here.

Feb 9 2021, 8:42 AM
donner added inline comments to D28549: Fix blackhole/reject routes..
Feb 9 2021, 7:36 AM

Feb 8 2021

donner added a reviewer for D28546: netgraph/ng_bridge: Document staleness in multithreaded operation: network.
Feb 8 2021, 10:13 PM
donner requested review of D28546: netgraph/ng_bridge: Document staleness in multithreaded operation.
Feb 8 2021, 10:11 PM
donner updated the diff for D28545: netgraph/ng_bridge: Merge internal host entry structures..
  • Get rid of "hent" instead of "host".
Feb 8 2021, 9:37 PM
donner added a reviewer for D28545: netgraph/ng_bridge: Merge internal host entry structures.: network.
Feb 8 2021, 9:33 PM
donner requested review of D28545: netgraph/ng_bridge: Merge internal host entry structures..
Feb 8 2021, 9:18 PM
donner closed D23840: netgraph/ng_base: Allow larger BINARY2ASCII conversions.
Feb 8 2021, 1:36 PM
donner committed rG45d75e3ac3fb: netgraph/ng_base: Allow larger BINARY2ASCII conversions (authored by donner).
netgraph/ng_base: Allow larger BINARY2ASCII conversions
Feb 8 2021, 1:36 PM
donner requested review of D28537: netgraph/ng_bridge: Add counters for the first link, too..
Feb 8 2021, 1:29 PM
donner updated the diff for D28123: netgraph/ng_bridge: become multithreaded.

Because the Phabricator dependencies are now in place: Make it happen

Feb 8 2021, 9:31 AM

Feb 7 2021

donner updated the diff for D23586: ipfw_nat: Perfomance of accessing multiple nat tables.

Rebase after a long time

Feb 7 2021, 9:26 PM
donner updated the diff for D23850: netgraph: Allow larger messages in communication between kernel and user-space.

Rebase after long time

Feb 7 2021, 9:14 PM
donner updated the diff for D23840: netgraph/ng_base: Allow larger BINARY2ASCII conversions.

Rebase after a long time

Feb 7 2021, 9:09 PM
donner committed rG6117aa58fa4f: netgraph/ng_bridge: Make simple internal functions read-only (authored by donner).
netgraph/ng_bridge: Make simple internal functions read-only
Feb 7 2021, 7:37 PM
donner added a reverting change for rGbb67e52db143: netgraph/ng_bridge: Make simple internal functions read-only: rGcef689f45b9d: Revert "netgraph/ng_bridge: Make simple internal functions read-only".
Feb 7 2021, 4:41 PM
donner committed rGcef689f45b9d: Revert "netgraph/ng_bridge: Make simple internal functions read-only" (authored by donner).
Revert "netgraph/ng_bridge: Make simple internal functions read-only"
Feb 7 2021, 4:41 PM
donner added a reverting change for D28141: netgraph/ng_bridge: Make simple internal functions read-only: rGcef689f45b9d: Revert "netgraph/ng_bridge: Make simple internal functions read-only".
Feb 7 2021, 4:41 PM
donner committed rGbb67e52db143: netgraph/ng_bridge: Make simple internal functions read-only (authored by donner).
netgraph/ng_bridge: Make simple internal functions read-only
Feb 7 2021, 2:41 PM
donner closed D28141: netgraph/ng_bridge: Make simple internal functions read-only.
Feb 7 2021, 2:41 PM
donner closed D28518: netgraph/ng_bridge: Remove old table ABI.
Feb 7 2021, 2:33 PM
donner committed rGed0a1527507e: netgraph/ng_bridge: Remove old table ABI (authored by donner).
netgraph/ng_bridge: Remove old table ABI
Feb 7 2021, 2:33 PM
donner added a comment to D28518: netgraph/ng_bridge: Remove old table ABI.

In stable/13 I'll only remove the '#define'. Older releases will not be touched.

Feb 7 2021, 12:06 PM

Feb 6 2021

donner added a reviewer for D28518: netgraph/ng_bridge: Remove old table ABI: network.
Feb 6 2021, 10:13 PM
donner requested review of D28518: netgraph/ng_bridge: Remove old table ABI.
Feb 6 2021, 10:12 PM
donner added a reviewer for D28516: netgraph/ng_bridge: learn MACs via control message: network.
Feb 6 2021, 9:59 PM
donner requested review of D28516: netgraph/ng_bridge: learn MACs via control message.
Feb 6 2021, 9:58 PM
donner updated the diff for D28141: netgraph/ng_bridge: Make simple internal functions read-only.

Rebase due to major changes

Feb 6 2021, 7:50 PM
donner updated the diff for D28144: netgraph/ng_bridge: switch loopCount to counter framework.

Rebase after several changes to the orginal source

Feb 6 2021, 7:11 PM
donner committed rG66c72859f66d: netgraph/ng_bridge: switch stats to counter framework (authored by donner).
netgraph/ng_bridge: switch stats to counter framework
Feb 6 2021, 5:18 PM
donner closed D28125: netgraph/ng_bridge: switch to counter framework.
Feb 6 2021, 5:18 PM
donner added reviewers for D28125: netgraph/ng_bridge: switch to counter framework: kp, philip.
Feb 6 2021, 2:19 PM
donner updated the diff for D28125: netgraph/ng_bridge: switch to counter framework.

rebased to main

Feb 6 2021, 2:19 PM
donner committed rGc869d905baa4: netgraph/ng_bridge: Derive forwarding mode from first attached hook (authored by donner).
netgraph/ng_bridge: Derive forwarding mode from first attached hook
Feb 6 2021, 2:04 PM
donner closed D28487: netgraph/ng_bridge: Derive forwarding mode from first attached hook.
Feb 6 2021, 2:04 PM
donner updated the diff for D28487: netgraph/ng_bridge: Derive forwarding mode from first attached hook.
  • rebased after landing man page modifications
Feb 6 2021, 10:40 AM
donner closed D28510: ng_bridge.4: Use more suitable manual macros.
Feb 6 2021, 10:37 AM
donner committed rG689561d40322: ng_bridge.4: Use more suitable mandoc macros (authored by donner).
ng_bridge.4: Use more suitable mandoc macros
Feb 6 2021, 10:37 AM
donner updated the diff for D28487: netgraph/ng_bridge: Derive forwarding mode from first attached hook.
  • rebased after landing parent
  • Switch to the new man page macros
Feb 6 2021, 10:27 AM
donner committed rGf961caf2184c: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning (authored by donner).
netgraph/ng_bridge: Introduce "uplink" ports without MAC learning
Feb 6 2021, 10:12 AM
donner closed D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
Feb 6 2021, 10:12 AM

Feb 5 2021

donner requested review of D28510: ng_bridge.4: Use more suitable manual macros.
Feb 5 2021, 9:27 PM
donner added inline comments to D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
Feb 5 2021, 8:40 PM
donner added inline comments to D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
Feb 5 2021, 8:40 PM
donner updated the diff for D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.

Incooperate suggestions.

Feb 5 2021, 8:40 PM
donner updated the diff for D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.
  • Remove debug output
Feb 5 2021, 11:25 AM
donner requested review of D28487: netgraph/ng_bridge: Derive forwarding mode from first attached hook.
Feb 5 2021, 8:07 AM
donner added reviewers for D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning: kp, philip.
Feb 5 2021, 7:35 AM
donner updated the diff for D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.

Remove the functional extension from this review. It will come as a
separate stacked one to ease reviewing.

Feb 5 2021, 7:33 AM

Feb 2 2021

donner added a comment to D23450: libalias: Allow setting alias port ranges.

Congrats @nc for the src bit.
Your turn!

Feb 2 2021, 9:19 PM
donner committed rGa2c37aa836c0: ixl: Permit 802.1ad frames to pass though the chip (authored by donner).
ixl: Permit 802.1ad frames to pass though the chip
Feb 2 2021, 2:44 PM
donner committed rG9c40fca6c809: ixl: Permit 802.1ad frames to pass though the chip (authored by donner).
ixl: Permit 802.1ad frames to pass though the chip
Feb 2 2021, 2:27 PM

Feb 1 2021

donner added a comment to D28447: Fix SIGBUS in ipfw(8) when ext6hdr option is omitted..

May you please provide the bug report or/and a test case.
Thanks

Feb 1 2021, 6:43 PM
donner committed rG90d158c0cf25: netgraph/ng_tag: permit variable length data (authored by donner).
netgraph/ng_tag: permit variable length data
Feb 1 2021, 2:08 PM
donner committed rG305b3ca5f40c: netgraph/ng_tag: permit variable length data (authored by donner).
netgraph/ng_tag: permit variable length data
Feb 1 2021, 1:59 PM

Jan 30 2021

donner accepted D28425: bridge: fix STP roles and protos strings.

The more interesting question is, why this went through undetected.

Jan 30 2021, 2:17 PM
donner accepted D28423: Enable multipath routing by default..

Waiting for it.

Jan 30 2021, 8:04 AM

Jan 29 2021

donner committed rGebc61c86b556: netgraph/ng_source: Switch queuing framework (authored by donner).
netgraph/ng_source: Switch queuing framework
Jan 29 2021, 11:39 AM
donner closed D28407: netgraph/ng_source: Switch queuing framework.
Jan 29 2021, 11:39 AM
donner updated the diff for D28407: netgraph/ng_source: Switch queuing framework.
  • Make assumption explicit.
Jan 29 2021, 11:03 AM
donner added inline comments to D28407: netgraph/ng_source: Switch queuing framework.
Jan 29 2021, 10:38 AM
donner updated the diff for D28407: netgraph/ng_source: Switch queuing framework.
  • Explain, why it's safe to ignore the error code.
Jan 29 2021, 10:37 AM
donner added inline comments to D28407: netgraph/ng_source: Switch queuing framework.
Jan 29 2021, 10:21 AM
donner added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

While we are here, may you reformat the code to match style(9).
swicth and case does line up:

Jan 29 2021, 10:17 AM · network
donner added inline comments to D28407: netgraph/ng_source: Switch queuing framework.
Jan 29 2021, 10:11 AM
lwhsu renamed donner from lutz_donnerhacke.de to donner.
Jan 29 2021, 6:41 AM

Jan 28 2021

donner updated the diff for D28407: netgraph/ng_source: Switch queuing framework.
  • Add initializer
Jan 28 2021, 10:37 PM
donner added inline comments to D28407: netgraph/ng_source: Switch queuing framework.
Jan 28 2021, 10:19 PM
donner retitled D28407: netgraph/ng_source: Switch queuing framework from netgraph/ng_sourche: Switch queuing framework to netgraph/ng_source: Switch queuing framework.
Jan 28 2021, 10:17 PM
donner requested review of D28407: netgraph/ng_source: Switch queuing framework.
Jan 28 2021, 10:17 PM

Jan 27 2021

donner updated the diff for D22110: netgraph/ng_car: Add color marking code.
  • bump man page date
  • rebase to current main
Jan 27 2021, 8:19 PM
donner accepted D28362: pf: Improve pf_rule input validation.

Okay.

Jan 27 2021, 2:38 PM

Jan 26 2021

donner added inline comments to D28362: pf: Improve pf_rule input validation.
Jan 26 2021, 8:28 PM
donner added inline comments to D28362: pf: Improve pf_rule input validation.
Jan 26 2021, 8:22 PM
donner updated the diff for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
  • Fix man page nits.
  • Removed false history from man page.
Jan 26 2021, 3:51 PM
donner updated the diff for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
  • Fix man page nits.
Jan 26 2021, 3:07 PM
donner added a comment to D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

@brueffer are your concerns still relevant?

Jan 26 2021, 2:43 PM
donner added inline comments to D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
Jan 26 2021, 8:46 AM
donner updated the diff for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
  • Fix spelling error.
Jan 26 2021, 8:45 AM
donner updated the diff for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
  • Converted from subversion
  • Switch to counter framework for statistics
  • Fix style(9) errors
  • Bump dates
Jan 26 2021, 8:44 AM

Jan 25 2021

donner accepted D28303: altq tests: Basic ALTQ test.
Jan 25 2021, 3:23 PM
donner accepted D28302: Add FEATURE sysctls for ALTQ disciplines.
Jan 25 2021, 3:21 PM

Jan 24 2021

donner removed a member for transport: donner.
Jan 24 2021, 10:21 PM

Jan 23 2021

donner added a comment to D28302: Add FEATURE sysctls for ALTQ disciplines.

We can also view it as 8 more out of ~8400 sysctls already present. And only on ALTQ enabled kernels, which is not default.

Jan 23 2021, 1:45 PM
donner accepted D28305: pfctl: FreeBSD now supports DIOCGIFSPEED.

LTGM

Jan 23 2021, 1:39 PM
donner accepted D28304: altq: Remove unused arguments from altq_attach().

LGTM

Jan 23 2021, 1:07 PM
donner added inline comments to D28303: altq tests: Basic ALTQ test.
Jan 23 2021, 1:05 PM
donner added a comment to D28302: Add FEATURE sysctls for ALTQ disciplines.

Sysctls are considered as an expensive activity, so they need to be justified.

Jan 23 2021, 12:58 PM

Jan 21 2021

donner accepted D28246: Further refactor IPv4 interface route creation..
Jan 21 2021, 7:01 AM

Jan 20 2021

donner added inline comments to D28246: Further refactor IPv4 interface route creation..
Jan 20 2021, 7:59 AM

Jan 19 2021

donner updated the diff for D24179: ixl: Permit 802.1ad frames to pass though the chip.
  • Bump document date and fix capitalization
Jan 19 2021, 2:57 PM
donner updated the diff for D24179: ixl: Permit 802.1ad frames to pass though the chip.
  • Fix man page style.
Jan 19 2021, 12:54 PM
donner added inline comments to D24179: ixl: Permit 802.1ad frames to pass though the chip.
Jan 19 2021, 12:45 PM
donner added a comment to D24179: ixl: Permit 802.1ad frames to pass though the chip.

I am okay with this in principle, modulo the documentation nitpicking, but I wonder if it wouldn't be better to change the *default* to something more sensible -- i.e., have 802.1ad work out of the box. One of the "local experimentation" types come to mind. Or set it to one of the types assigned to Intel!

http://standards-oui.ieee.org/ethertype/eth.txt

What do other operating systems do?

Jan 19 2021, 12:44 PM
donner updated the diff for D24179: ixl: Permit 802.1ad frames to pass though the chip.
  • fixing style(9)
  • adding documentation for the hack
Jan 19 2021, 12:02 AM

Jan 17 2021

donner updated the diff for D21968: netgraph/ng_source: Allow ng_source to inject into any netgraph network.

Bump the date in the man page.

Jan 17 2021, 8:40 PM
donner updated the diff for D27968: Add myself (donner) as src committer..
  • Update the day of the commit bit assignment.
Jan 17 2021, 12:01 PM