Page MenuHomeFreeBSD

netgraph/ng_bridge: switch to counter framework
AcceptedPublic

Authored by lutz_donnerhacke.de on Tue, Jan 12, 10:27 PM.

Details

Reviewers
melifaro
afedorov
Group Reviewers
network
Summary

Switch to counter framework for per interface stats in ng_bridge.

Depends on D28123

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 36161
Build 33050: arc lint + arc unit

Event Timeline

LGTM. Does it really depend on D28123?

sys/netgraph/ng_bridge.c
92

Maybe _kstats?

440

_statS() for consistency?

This revision is now accepted and ready to land.Wed, Jan 13, 1:16 AM

LGTM. Does it really depend on D28123?

Formally the change does not require D28123 to be applied.
It's a reverse dependency: Many changes are necessary to remove the WRITER annotation.

Without the motivation of D28123, this change is senseless.

Is there a better way to organize a bunch of prerequisite changes?

Choose better names as suggested by melifaro.

This revision now requires review to proceed.Wed, Jan 13, 6:20 AM

Reversing errornously included stacked commit.

This revision is now accepted and ready to land.Wed, Jan 13, 7:44 AM