⚙ D28125 netgraph/ng_bridge: switch to counter framework

donner created this revision.Jan 12 2021, 10:27 PM

Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptJan 12 2021, 10:27 PM

Harbormaster completed remote builds in B36153: Diff 82178.Jan 12 2021, 10:27 PM

donner requested review of this revision.Jan 12 2021, 10:27 PM

donner added a reviewer: network.Jan 12 2021, 10:35 PM

LGTM. Does it really depend on D28123?

sys/netgraph/ng_bridge.c
93	Maybe _kstats?
450	_statS() for consistency?

This revision is now accepted and ready to land.Jan 13 2021, 1:16 AM

In D28125#628582, @melifaro wrote:

LGTM. Does it really depend on D28123?

Formally the change does not require D28123 to be applied.
It's a reverse dependency: Many changes are necessary to remove the WRITER annotation.

Without the motivation of D28123, this change is senseless.

Is there a better way to organize a bunch of prerequisite changes?

Choose better names as suggested by melifaro.

This revision now requires review to proceed.Jan 13 2021, 6:20 AM

Harbormaster completed remote builds in B36160: Diff 82191.Jan 13 2021, 6:20 AM

donner marked 2 inline comments as done.Jan 13 2021, 6:21 AM

Reversing errornously included stacked commit.

Harbormaster completed remote builds in B36161: Diff 82192.Jan 13 2021, 6:23 AM

afedorov added a subscriber: afedorov.Jan 13 2021, 7:36 AM

afedorov accepted this revision.Jan 13 2021, 7:43 AM

afedorov added a reviewer: afedorov.

This revision is now accepted and ready to land.Jan 13 2021, 7:44 AM

donner added a child revision: D28144: netgraph/ng_bridge: switch loopCount to counter framework.Jan 13 2021, 11:19 PM

rebased to main

This revision now requires review to proceed.Feb 6 2021, 2:18 PM

Harbormaster completed remote builds in B36754: Diff 83458.Feb 6 2021, 2:19 PM

donner added reviewers: kp, philip.Feb 6 2021, 2:19 PM

donner removed a parent revision: D28123: netgraph/ng_bridge: become multithreaded.Feb 6 2021, 4:35 PM

donner added a child revision: D28123: netgraph/ng_bridge: become multithreaded.

donner removed a child revision: D28123: netgraph/ng_bridge: become multithreaded.

donner added a child revision: D28123: netgraph/ng_bridge: become multithreaded.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2021, 5:18 PM

Closed by commit rG66c72859f66d: netgraph/ng_bridge: switch stats to counter framework (authored by donner). · Explain Why

This revision was automatically updated to reflect the committed changes.

donner added a commit: rG66c72859f66d: netgraph/ng_bridge: switch stats to counter framework.

donner added a commit: rGd7187b4b1c70: netgraph/ng_bridge: switch stats to counter framework.Feb 22 2021, 8:38 AM

donner added a commit: rGbfe0d8ca0b88: netgraph/ng_bridge: switch stats to counter framework.Feb 25 2021, 8:15 AM

netgraph/ng_bridge: switch to counter framework
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 83462

sys/netgraph/ng_bridge.c

netgraph/ng_bridge: switch to counter frameworkClosedPublicActions