Page MenuHomeFreeBSD

altq tests: Basic ALTQ test
ClosedPublic

Authored by kp on Jan 23 2021, 10:52 AM.

Details

Summary

Activate ALTQ_HFSC, crudely check if it really limits bandwidth as we'd expect.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Jan 23 2021, 10:52 AM
donner added inline comments.
tests/sys/netpfil/pf/altq.sh
25

It's expected, that this command always succeed, so there is no check needed. Correct?

37

There is a race condition between the "saturate" ping and the test. A busy system might have several seconds between those commands.

Would it be possible to rephrase the check, so that the ping is sending i.e. 10 packets and we expect 3 of them back?

Adjust to new altq.foo sysctl

This revision is now accepted and ready to land.Jan 25 2021, 3:23 PM
This revision was automatically updated to reflect the committed changes.