Differential D28303

altq tests: Basic ALTQ test
ClosedPublic
Actions

Authored by kp on Jan 23 2021, 10:52 AM.

Tags

None

Referenced Files

	F108517045: D28303.id82852.diff
	Sat, Jan 25, 7:56 PM

	F108511890: D28303.id82763.diff
	Sat, Jan 25, 7:14 PM

	F108511813: D28303.id82870.diff
	Sat, Jan 25, 7:13 PM

	Unknown Object (File)
	Thu, Jan 23, 8:27 PM

	Unknown Object (File)
	Fri, Jan 3, 10:38 AM

	Unknown Object (File)
	Dec 22 2024, 8:50 PM

	Unknown Object (File)
	Dec 4 2024, 8:25 PM

	Unknown Object (File)
	Nov 26 2024, 6:00 PM

View All 65 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG2400173b9377: altq tests: Basic ALTQ test
rGe02597d7ce67: altq tests: Basic ALTQ test
rG16b3833344ad: altq tests: Basic ALTQ test

Summary

Activate ALTQ_HFSC, crudely check if it really limits bandwidth as we'd expect.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jan 23 2021, 10:52 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptJan 23 2021, 10:52 AM

kp requested review of this revision.Jan 23 2021, 10:52 AM

Harbormaster completed remote builds in B36429: Diff 82763.Jan 23 2021, 10:52 AM

donner added a subscriber: donner.Jan 23 2021, 1:05 PM

donner added inline comments.

tests/sys/netpfil/pf/altq.sh
26	It's expected, that this command always succeed, so there is no check needed. Correct?
38	There is a race condition between the "saturate" ping and the test. A busy system might have several seconds between those commands. Would it be possible to rephrase the check, so that the ping is sending i.e. 10 packets and we expect 3 of them back?

Adjust to new altq.foo sysctl

Harbormaster completed remote builds in B36469: Diff 82852.Jan 25 2021, 3:17 PM

donner accepted this revision as: donner.Jan 25 2021, 3:23 PM

This revision is now accepted and ready to land.Jan 25 2021, 3:23 PM

Closed by commit rG16b3833344ad: altq tests: Basic ALTQ test (authored by kp). · Explain WhyJan 25 2021, 7:59 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG16b3833344ad: altq tests: Basic ALTQ test.

kp added a commit: rGe02597d7ce67: altq tests: Basic ALTQ test.Jul 31 2021, 1:04 PM

kp added a commit: rG2400173b9377: altq tests: Basic ALTQ test.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

3 lines

49 lines

24 lines

Diff 82870

tests/sys/netpfil/pf/Makefile

Loading...

tests/sys/netpfil/pf/altq.sh

Loading...

tests/sys/netpfil/pf/utils.subr

Loading...