Differential D28303

altq tests: Basic ALTQ test
ClosedPublic
Actions

Authored by kp on Jan 23 2021, 10:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 12:08 AM

	Unknown Object (File)
	Mar 10 2024, 1:49 PM

	Unknown Object (File)
	Jan 27 2024, 4:58 PM

	Unknown Object (File)
	Dec 20 2023, 4:15 AM

	Unknown Object (File)
	Dec 12 2023, 10:35 AM

	Unknown Object (File)
	Dec 3 2023, 6:00 PM

	Unknown Object (File)
	Nov 10 2023, 1:09 PM

	Unknown Object (File)
	Nov 8 2023, 1:03 PM

View All 32 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG2400173b9377: altq tests: Basic ALTQ test
rGe02597d7ce67: altq tests: Basic ALTQ test
rG16b3833344ad: altq tests: Basic ALTQ test

Summary

Activate ALTQ_HFSC, crudely check if it really limits bandwidth as we'd expect.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36429
Build 33318: arc lint + arc unit

Event Timeline

kp created this revision.Jan 23 2021, 10:52 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptJan 23 2021, 10:52 AM

kp requested review of this revision.Jan 23 2021, 10:52 AM

Harbormaster completed remote builds in B36429: Diff 82763.Jan 23 2021, 10:52 AM

donner added a subscriber: donner.Jan 23 2021, 1:05 PM

donner added inline comments.

tests/sys/netpfil/pf/altq.sh
25	It's expected, that this command always succeed, so there is no check needed. Correct?
37	There is a race condition between the "saturate" ping and the test. A busy system might have several seconds between those commands. Would it be possible to rephrase the check, so that the ping is sending i.e. 10 packets and we expect 3 of them back?

Adjust to new altq.foo sysctl

Harbormaster completed remote builds in B36469: Diff 82852.Jan 25 2021, 3:17 PM

donner accepted this revision as: donner.Jan 25 2021, 3:23 PM

This revision is now accepted and ready to land.Jan 25 2021, 3:23 PM

Closed by commit rG16b3833344ad: altq tests: Basic ALTQ test (authored by kp). · Explain WhyJan 25 2021, 7:59 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG16b3833344ad: altq tests: Basic ALTQ test.

kp added a commit: rGe02597d7ce67: altq tests: Basic ALTQ test.Jul 31 2021, 1:04 PM

kp added a commit: rG2400173b9377: altq tests: Basic ALTQ test.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

3 lines

49 lines

24 lines

Diff 82763

tests/sys/netpfil/pf/Makefile

Loading...

tests/sys/netpfil/pf/altq.sh

Loading...

tests/sys/netpfil/pf/utils.subr

Loading...