Page MenuHomeFreeBSD

Add FEATURE sysctls for ALTQ disciplines
ClosedPublic

Authored by kp on Jan 23 2021, 10:52 AM.

Details

Summary

This will allow userspace to more easily figure out if ALTQ is built
into the kernel and what disciplines are supported.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Jan 23 2021, 10:52 AM

Sysctls are considered as an expensive activity, so they need to be justified.

We have currently 48 kern.feature entries in the GENERIC stable/12 kernel.
You propose to increase this number by 16%

Can you point me to a relevant use case?

In D28302#633137, @lutz_donnerhacke.de wrote:

Sysctls are considered as an expensive activity, so they need to be justified.

We have currently 48 kern.feature entries in the GENERIC stable/12 kernel.
You propose to increase this number by 16%

We can also view it as 8 more out of ~8400 sysctls already present. And only on ALTQ enabled kernels, which is not default.

Can you point me to a relevant use case?

My use case for this is to make the new altq test conditional on the presence of ALTQ in the kernel. In much the same way that the pf tests already check for kern.features.vimage

We can also view it as 8 more out of ~8400 sysctls already present. And only on ALTQ enabled kernels, which is not default.

Ok.

Can you point me to a relevant use case?

My use case for this is to make the new altq test conditional on the presence of ALTQ in the kernel. In much the same way that the pf tests already check for kern.features.vimage

How about introducing a hierarchy? Something like kern.feature.altq,.xxx ?
I know, that is not the typical usage, but it might be clearer than structuring with underscores and rely on the alphabetical sort.

Create kern.features.altq.<foo> rather than kern.features.altq_<foo>

This revision is now accepted and ready to land.Jan 25 2021, 3:21 PM
This revision was automatically updated to reflect the committed changes.