Very nice, give it a .Dd bump while you're at it. Thank you!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 15 2020
Thanks for these changes. I'll get them committed.
Jun 14 2020
Adding manu for his embedded expertise (more than mine anyway). :)
Great, thank you!
Yes, go ahead with the commit.
Minor typo.
Jun 13 2020
I found a few minor textual things to fix, quickly done. ;-)
Good, bump the .Dd when you commit. Thanks!
Two minor fixes, but nothing major.
Looking good, thanks for the research into the history of these pages/functions.
Sorry for the wait. Go ahead with the commit and pick an MFC time in a few days.
OK then. Thanks for following up on this.
Sure, go ahead. Bump the .Dd to the current date of the commit and set an MFC time of your choice.
Thanks!
Jun 12 2020
Ready to go, thank you!
Jun 11 2020
OK from manpages.
Sure you can commit if you don't have the required bit, but if someone(tm) with the required bit has approved it.
Jun 10 2020
Looking good, you can commit it after you've fixed the line break.
A fix and another example to add.
Looks good to me. Make sure to put
Good to go! Thanks for another man page with EXAMPLEs.
I'd use "will" instead of "shall".
Jun 9 2020
Remove link to the Speak Up! project as it seems to be dead.
Bolded the "In general, ..." bullet point for consistency.
Uppercase FreeBSD again (sorry Sean, it's more consistent with the rest of our web docs) and shorten the link to the reporting guidelines.
Minor updates (remove excess " in one email link and fix indentation).
Excellent, good to go (including the .Dd bump, of course).
Good to go (with a .Dd bump). Thanks for another man page with EXAMPLEs now. ;)
Jun 8 2020
I like the examples in general. I think they might be a bit long and couple probably be condensed a bit to still reflect the intended output. This avoids blowing up the man page with entries that are not being used. Maybe having just 3 - 5 is enough.
Great, thank you. Can you commit it yourself or should I do it?
Jun 7 2020
OK from manpages, with the usual .Dd bump when the commit happens.
These look good to me as examples. I'll commit them. Thank you!
Minor wording fix.
Jun 6 2020
Wow, this is great work and a very welcome addition to the developers handbook. Thank you for the initial writeup.
The developers-handbook has not seen many updates in recent years and many of the sections and chapters have a less formal writing style than the handbook. Perhaps this is because it was written by developers and the docs people did not get to give it a bit of formatting love yet.
Jun 5 2020
Good to go!
Jun 4 2020
Yeah, it can be done by a follow-up commit.
OK from manpages (bump .Dd when you commit). Thanks!
Jun 3 2020
Excellent, good to go now. Thank you!
OK from manpages. Ready to go. Thanks for having this constructive review!
Small wording fixes in the man page.
Mention the including last number and end each description with a colon (:).
Jun 1 2020
Two simple fixes for the man page.
May 30 2020
OK from manpages (don't forget to bump .Dd when committing).
Thanks for implementing this feature.
May 29 2020
Thanks (I'll tell that to my optometrist ;-)).
Found another typo...
Link to zshexpn with zsh-specific chars.
Looks good in general, only minor nits found. Thanks for that work.
Good to go. Don't forget to bump the .Dd.
May 27 2020
Comment about caret escaping in a popular shell...
OK from manpages.
May 24 2020
Looks good now, ready to commit (and MFC later)! Thank you.
May 23 2020
A comment about a sentence fragment. The rest looks good.
Do you know about textproc/igor? You can run it over the man page and it will give you some additional style tips and warnings. It will definitely complain about the .Dd not being set to today. For each content change that is relevant enough (like this one), we bump this to the date when the commit happens (i.e. when you get the approval).
Additionally, you can check the man page with "mandoc -Tlint" to see if there are some tags out of place or something.
May 22 2020
May 20 2020
OK from manpages, with the usual hint to bump the .Dd when the commit happens.
In D24916#548579, @jilles wrote:Although there is nothing wrong with this per se, applications can deal with this problem more easily using getline(3) (which is also standard).
May 19 2020
May 17 2020
May 16 2020
May 15 2020
OK from manpages. Sorry it took a while to review.
Good catch, I'll commit the fix.
Thank you!
OK from manpages.
May 14 2020
Thank you, Daniel. I think it is ready to commit now and will take care of it!
OK from manpages.
Good to go for the man page side of things.