Page MenuHomeFreeBSD
Differential D25240

sockstat(1): Add EXAMPLES to man page
AbandonedPublic
Actions

Authored by fernape on Jun 12 2020, 6:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:23 AM
Unknown Object (File)
Thu, May 2, 12:11 AM
Unknown Object (File)
Wed, May 1, 11:45 PM
Unknown Object (File)
Wed, May 1, 11:45 PM
Unknown Object (File)
Wed, May 1, 9:55 PM
Unknown Object (File)
Dec 20 2023, 8:27 AM
Unknown Object (File)
Dec 15 2023, 4:22 PM
Unknown Object (File)
Jun 16 2023, 3:30 AM
View All 11 Files
Subscribers
0mp
bcr
gbe
imp
Contributor Reviews (src)

Details

Reviewers
gbe
Group Reviewers
manpages
Summary
  • Add three examples showing the use of -4, -6, -l, -L, -p and -P
Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./sockstat.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31682
Build 29256: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 12 2020, 6:58 AM
Herald added a reviewer: manpages. · View Herald TranscriptJun 12 2020, 6:58 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Jun 12 2020, 6:58 AM
Harbormaster completed remote builds in B31653: Diff 73006.Jun 12 2020, 6:58 AM
gbe accepted this revision.Jun 13 2020, 7:48 AM
gbe added a subscriber: gbe.

Very small grammar issues, otherwise, thanks for the patch! :)

usr.bin/sockstat/sockstat.1
187

I would place a comma after UDP and after neither.

This revision is now accepted and ready to land.Jun 13 2020, 7:48 AM
fernape updated this revision to Diff 73071.Jun 13 2020, 4:07 PM
fernape edited the summary of this revision. (Show Details)

Fix grammer issues spotted by gbe

This revision now requires review to proceed.Jun 13 2020, 4:07 PM
Harbormaster completed remote builds in B31682: Diff 73071.Jun 13 2020, 4:07 PM
fernape marked an inline comment as done.Jun 13 2020, 4:07 PM

Thanks for the time reviewing this.

bcr accepted this revision as: manpages.Jun 13 2020, 5:07 PM
bcr added a subscriber: bcr.

Good to go now.

fernape added a comment.Jun 13 2020, 5:48 PM
In D25240#556990, @bcr wrote:

Good to go now.

Done in r362149 but I forgot to to reference the review in the commit :-( although I sent a follow up email
Is it possible to close this review? I can't find the Action to do that.

0mp added a subscriber: 0mp.Jun 13 2020, 5:51 PM
In D25240#557030, @fernape wrote:
In D25240#556990, @bcr wrote:

Good to go now.

Done in r362149 but I forgot to to reference the review in the commit :-( although I sent a follow up email
Is it possible to close this review? I can't find the Action to do that.

Maybe you can abandon it.

fernape abandoned this revision.Jun 13 2020, 6:23 PM
In D25240#556990, @bcr wrote:

Good to go now.

Done in r362149 but I forgot to to reference the review in the commit :-( although I sent a follow up email
Is it possible to close this review? I can't find the Action to do that.

Revision Contents
Changeset List

PathSize
usr.bin/
sockstat/
17 lines

Diff 73071

View Options

usr.bin/sockstat/sockstat.1

Loading...