Default Linux openfiles to 1024
ClosedPublic
Actions

Authored by trasz on Jun 7 2020, 4:32 PM.

Details

Reviewers

kevans
emaste

Group Reviewers

manpages
Linux Emulation

Commits

rS362015: Make linux(4) set the openfiles soft resource limit to 1024 for Linux

Summary

Make linux(4) set openfiles soft resource limit to 1024 for Linux
applications, which often depend on this being the case. There's
a new sysctl, compat.linux.default_openfiles, to control this
behaviour.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Jun 7 2020, 4:32 PM

Herald added a reviewer: manpages. · View Herald TranscriptJun 7 2020, 4:32 PM

Herald added a subscriber: imp. · View Herald Transcript

trasz requested review of this revision.Jun 7 2020, 4:32 PM

Harbormaster completed remote builds in B31548: Diff 72796.Jun 7 2020, 4:32 PM

trasz added a reviewer: Linux Emulation.Jun 7 2020, 4:34 PM

trasz mentioned this in D22585: Limit openfiles-cur to 1024.

OK from manpages, with the usual .Dd bump when the commit happens.

I think I'm orders of magnitude more comfortable with this change; it does indeed seem quite reasonable to default Linux applications out with the limits they're likely expecting.

This revision is now accepted and ready to land.Jun 7 2020, 11:17 PM

(Tinderboxed.)

emaste accepted this revision.Jun 8 2020, 6:52 PM

emaste added a subscriber: emaste.

emaste added inline comments.

share/man/man4/linux.4
100 ↗	(On Diff #72796)	I might s/it/the limit/.
sys/compat/linux/linux_mib.c
68 ↗	(On Diff #72796)	Maybe add ", or -1 for unlimited" or similar to the description string?