Page MenuHomeFreeBSD

Default Linux openfiles to 1024
ClosedPublic

Authored by trasz on Jun 7 2020, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 10:42 AM
Unknown Object (File)
Oct 19 2024, 1:35 AM
Unknown Object (File)
Oct 18 2024, 5:33 AM
Unknown Object (File)
Oct 10 2024, 4:50 AM
Unknown Object (File)
Oct 2 2024, 7:00 AM
Unknown Object (File)
Oct 1 2024, 3:31 PM
Unknown Object (File)
Oct 1 2024, 3:25 PM
Unknown Object (File)
Oct 1 2024, 1:41 PM

Details

Summary

Make linux(4) set openfiles soft resource limit to 1024 for Linux
applications, which often depend on this being the case. There's
a new sysctl, compat.linux.default_openfiles, to control this
behaviour.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Jun 7 2020, 4:32 PM
bcr added a subscriber: bcr.

OK from manpages, with the usual .Dd bump when the commit happens.

kevans added a subscriber: kevans.

I think I'm orders of magnitude more comfortable with this change; it does indeed seem quite reasonable to default Linux applications out with the limits they're likely expecting.

This revision is now accepted and ready to land.Jun 7 2020, 11:17 PM
emaste added a subscriber: emaste.
emaste added inline comments.
share/man/man4/linux.4
100 ↗(On Diff #72796)

I might s/it/the limit/.

sys/compat/linux/linux_mib.c
68 ↗(On Diff #72796)

Maybe add ", or -1 for unlimited" or similar to the description string?