Page MenuHomeFreeBSD
Differential D25199

Add myself (gbe) as doc committer
ClosedPublic
Actions

Authored by gbe on Jun 9 2020, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 7 2024, 2:04 PM
Unknown Object (File)
May 2 2024, 12:11 AM
Unknown Object (File)
May 1 2024, 11:51 PM
Unknown Object (File)
May 1 2024, 11:48 PM
Unknown Object (File)
May 1 2024, 11:47 PM
Unknown Object (File)
May 1 2024, 11:16 PM
Unknown Object (File)
May 1 2024, 11:16 PM
Unknown Object (File)
May 1 2024, 9:55 PM
View All 20 Files
Subscribers
None

Details

Reviewers
bcr
Commits
rD54244: Add myself (gbe) as doc committer
Summary

Add myself (gbe) as doc committer

Approved by: bcr (mentor)

Test Plan

build the handbook

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gbe requested review of this revision.Jun 9 2020, 3:38 PM
gbe created this revision.
Harbormaster completed remote builds in B31585: Diff 72861.Jun 9 2020, 3:38 PM
bcr added a comment.Jun 9 2020, 8:27 PM

Minor fix.

en_US.ISO8859-1/articles/contributors/contrib.committers.xml
104 ↗(On Diff #72861)

The indentation is a bit off. Compare to the entries above and/or below.

gbe updated this revision to Diff 72920.Jun 10 2020, 11:17 AM
  • Fix identation, space instead of tabs
  • Add my (gbe) PGP key
Harbormaster completed remote builds in B31607: Diff 72920.Jun 10 2020, 11:17 AM
gbe updated this revision to Diff 72921.Jun 10 2020, 11:55 AM
  • Add news about me beeing a new committer
Harbormaster completed remote builds in B31608: Diff 72921.Jun 10 2020, 11:55 AM
bcr accepted this revision.Jun 10 2020, 3:12 PM

Looks good to me. Make sure to put

"Approved by:<tab>bcr(mentor)"

(without the quotes) into the commit message so that people see that you are my Padawan and complain to me instead of you if you make any mistakes.

Happy first commit!

share/xml/news.xml
37 ↗(On Diff #72921)

Be aware that there has been a new entry been made in the meantime, so you might need to merge yours into the current version. The date of the entry is the date when the commit bit was granted, so keep the date and not put it on top of the current entry.

This revision is now accepted and ready to land.Jun 10 2020, 3:12 PM
gbe updated this revision to Diff 72989.Jun 11 2020, 5:30 PM
This revision now requires review to proceed.Jun 11 2020, 5:30 PM
Harbormaster completed remote builds in B31641: Diff 72989.Jun 11 2020, 5:30 PM
bcr accepted this revision.Jun 11 2020, 7:16 PM
This revision is now accepted and ready to land.Jun 11 2020, 7:16 PM
Closed by commit rD54244: Add myself (gbe) as doc committer (authored by gbe). · Explain WhyJun 11 2020, 7:33 PM
This revision was automatically updated to reflect the committed changes.
gbe added a commit: rD54244: Add myself (gbe) as doc committer.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
articles/
contributors/
4 lines
share/
pgpkeys/
5 lines
1 line
xml/
3 lines
25 lines

Diff 72994

View Options

head/en_US.ISO8859-1/articles/contributors/contrib.committers.xml

Loading...
View Options

head/share/pgpkeys/pgpkeys-developers.xml

Loading...
View Options

head/share/pgpkeys/pgpkeys.ent

Loading...
View Options

head/share/xml/authors.ent

Loading...
View Options

head/share/xml/news.xml

Loading...