Page MenuHomeFreeBSD
Differential D25172

articles/contributing: Suggest checking build warnings through our CI
ClosedPublic
Actions

Authored by salvadore on Jun 6 2020, 11:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 6:21 AM
Unknown Object (File)
Sat, Nov 1, 4:53 PM
Unknown Object (File)
Sat, Nov 1, 4:53 PM
Unknown Object (File)
Sat, Nov 1, 4:53 PM
Unknown Object (File)
Sat, Nov 1, 4:53 PM
Unknown Object (File)
Sat, Nov 1, 12:32 PM
Unknown Object (File)
Tue, Oct 28, 8:47 AM
Unknown Object (File)
Sun, Oct 26, 11:36 PM
View All 95 Files
Subscribers
bcr

Details

Reviewers
lwhsu
bcr
Group Reviewers
docs
Commits
rD54220: articles/contributing: Suggest checking build warnings through our CI

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

salvadore requested review of this revision.Jun 6 2020, 11:16 PM
salvadore created this revision.
Harbormaster completed remote builds in B31543: Diff 72784.Jun 6 2020, 11:16 PM
bcr added a subscriber: bcr.Jun 7 2020, 1:06 PM

Minor wording fix.

head/en_US.ISO8859-1/articles/contributing/article.xml
166–169

The use of "You" is discouraged, see here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style.html

You can write "A list of build warnings from our CI is obtained by selecting a build and checking "LLVM/Clang Warning" or similar.

salvadore updated this revision to Diff 72800.Jun 7 2020, 8:02 PM

Remove the use of "You".

@bcr: Thanks for your comment!

Harbormaster completed remote builds in B31551: Diff 72800.Jun 7 2020, 8:03 PM
salvadore marked an inline comment as done.Jun 7 2020, 8:03 PM
bcr accepted this revision.Jun 8 2020, 5:58 AM

Great, thank you. Can you commit it yourself or should I do it?

This revision is now accepted and ready to land.Jun 8 2020, 5:58 AM
salvadore added a comment.EditedJun 8 2020, 9:51 AM

I can commit it and I will do it in a minute.
Thanks!

Closed by commit rD54220: articles/contributing: Suggest checking build warnings through our CI (authored by salvadore). · Explain WhyJun 8 2020, 9:55 AM
This revision was automatically updated to reflect the committed changes.
salvadore added a commit: rD54220: articles/contributing: Suggest checking build warnings through our CI.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
articles/
contributing/
5 lines

Diff 72819

View Options

head/en_US.ISO8859-1/articles/contributing/article.xml

Loading...