Oh, I just saw the WITHOUT_ file was added in your other review.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 26 2018
Isn't WITH_LLVM_TARGET_ALL the default, and if so, shouldn't WITHOUT_LLVM_TARGET_ALL be documented instead? (I always found these explanatory files a little confusing, though...)
Hm, I wasn't even aware of this awful hack. So for some test that runs with one of the sanitizers, it requires the clang_rt libs at world build time? E.g. we should maybe build these as part of cross-tools at some point?
Jun 22 2018
Jun 21 2018
- Rebased against recent head
- Only add targets which are currently supported
- Added check for at least one enabled target
- Use for loop instead of individual target checks
Jun 19 2018
Jun 18 2018
Jun 17 2018
Jun 15 2018
Jun 13 2018
Jun 11 2018
Btw, this will be a direct commit to stable/11, since si was removed from head.
Jun 10 2018
Jun 9 2018
Jun 7 2018
Jun 3 2018
May 31 2018
Completely revise approach, by letting lib/msun include <ieeefp.h>,
and defining all the common macros in the amd64 and i386 versions of
ieeefp.h instead. Those macros now use pointers as arguments, and
call sites have been updated.
In D15633#330244, @kib wrote:In D15633#330243, @dim wrote:In D15633#330225, @kib wrote:Do arg-less macro conflict ? I think that no, and then there is no need to rename, use the __HAVE_MACRO_NAME trick to detect the presence of the macro in the namespace.
I don't think they do, but it's also more complicated to do it this way.
Why do you consider it more complicated ?
In D15633#330225, @kib wrote:Do arg-less macro conflict ? I think that no, and then there is no need to rename, use the __HAVE_MACRO_NAME trick to detect the presence of the macro in the namespace.
Re-uploading, with a few changes:
- Removed the userboot changes, since rS334412 is a better fix
- Use -Wno-unitialized with gcc 4.2.1 for cd9660read.c
- Use -march=i386 instead of -mcpu=i386 in defs.mk. The gcc documentation states that -mcpu is a deprecated synonym for -mtune, but -mtune does not prevent instructions "higher" than i386, it merely tunes for them.
May 30 2018
LGTM now.
May 20 2018
May 17 2018
Apr 27 2018
Apr 23 2018
Apr 21 2018
Apr 20 2018
Apr 17 2018
LGTM
Apr 14 2018
Apr 11 2018
Mar 31 2018
Mar 30 2018
@jim_netgate.com, does this trick work for both clang and gcc (both base and newer)? If so, I think this would be fine to commit. explicit_bzero could even be a macro! (And there might be a corresponding explicit_memset too, but I digress.)
Mar 29 2018
Mar 27 2018
Mar 22 2018
Mar 19 2018
This has been committed now.
Mar 17 2018
Remove auto-added Subversion properties.
In D14720#309378, @emaste wrote:IndirectBrExpandPass.cpp and X86RetpolineThunks.cpp have unintended SVN properties in the diff it seems