Page MenuHomeFreeBSD
Feed Advanced Search

Jun 26 2018

dim accepted D16021: Clang: Only build needed target for bootstrap compiler..

Oh, I just saw the WITHOUT_ file was added in your other review.

Jun 26 2018, 11:20 PM
dim added inline comments to D16020: Add LLVM_TARGET_ALL option..
Jun 26 2018, 11:19 PM
dim added a comment to D16021: Clang: Only build needed target for bootstrap compiler..

Isn't WITH_LLVM_TARGET_ALL the default, and if so, shouldn't WITHOUT_LLVM_TARGET_ALL be documented instead? (I always found these explanatory files a little confusing, though...)

Jun 26 2018, 11:17 PM
dim accepted D16012: Rework check for libclang_rt to see if the needed library exists..

Hm, I wasn't even aware of this awful hack. So for some test that runs with one of the sanitizers, it requires the clang_rt libs at world build time? E.g. we should maybe build these as part of cross-tools at some point?

Jun 26 2018, 9:38 AM

Jun 22 2018

dim committed rS335558: Add support for selectively enabling LLVM targets.
Add support for selectively enabling LLVM targets
Jun 22 2018, 3:00 PM
dim closed D11077: Add support for selectively enabling/disabling LLVM targets.
Jun 22 2018, 3:00 PM
dim retitled D11077: Add support for selectively enabling/disabling LLVM targets from WIP: Add support for selectively turning on LLVM targets to Add support for selectively enabling/disabling LLVM targets.
Jun 22 2018, 9:44 AM

Jun 21 2018

dim updated the diff for D11077: Add support for selectively enabling/disabling LLVM targets.
  • Rebased against recent head
  • Only add targets which are currently supported
  • Added check for at least one enabled target
  • Use for loop instead of individual target checks
Jun 21 2018, 6:00 PM
dim committed rS335472: MFC r335297:.
MFC r335297:
Jun 21 2018, 9:45 AM
dim committed rS335471: MFC r335296:.
MFC r335296:
Jun 21 2018, 9:41 AM

Jun 19 2018

dim added inline comments to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..
Jun 19 2018, 4:06 PM

Jun 18 2018

dim committed rS335340: Follow-up to r335289, which merged r334948 from head, to really fix the.
Follow-up to r335289, which merged r334948 from head, to really fix the
Jun 18 2018, 8:43 PM

Jun 17 2018

dim committed rS335297: Fix build of ndis with base gcc on i386.
Fix build of ndis with base gcc on i386
Jun 17 2018, 7:25 PM
dim closed D15746: Fix build of ndis with base gcc on i386.
Jun 17 2018, 7:24 PM
dim committed rS335296: Fix build of aibs with base gcc on i386.
Fix build of aibs with base gcc on i386
Jun 17 2018, 7:14 PM
dim closed D15725: Fix build of atk0110 with base gcc on i386.
Jun 17 2018, 7:14 PM
dim committed rS335293: MFC r335034:.
MFC r335034:
Jun 17 2018, 5:38 PM
dim committed rS335292: MFC r334947:.
MFC r334947:
Jun 17 2018, 5:35 PM
dim committed rS335291: MFC r334945:.
MFC r334945:
Jun 17 2018, 5:32 PM
dim committed rS335289: MFC r334948:.
MFC r334948:
Jun 17 2018, 5:28 PM
dim committed rS335288: MFC r334946:.
MFC r334946:
Jun 17 2018, 5:25 PM

Jun 15 2018

dim added a comment to D15753: Fix build of hyperv with base gcc on i386.

Ping.

Jun 15 2018, 7:51 PM
dim added a comment to D15746: Fix build of ndis with base gcc on i386.

Ping.

Jun 15 2018, 7:51 PM
dim added a comment to D15725: Fix build of atk0110 with base gcc on i386.

Ping.

Jun 15 2018, 7:51 PM

Jun 13 2018

dim committed rS335088: MFC r334886:.
MFC r334886:
Jun 13 2018, 8:36 PM
dim committed rS335087: Fix build of si with base gcc on i386.
Fix build of si with base gcc on i386
Jun 13 2018, 8:34 PM
dim closed D15752: Fix build of si with base gcc on i386.
Jun 13 2018, 8:34 PM
dim committed rS335034: Fix build of liquidio with base gcc on i386.
Fix build of liquidio with base gcc on i386
Jun 13 2018, 7:56 AM
dim closed D15754: Fix build of liquidio with base gcc on i386.
Jun 13 2018, 7:56 AM

Jun 11 2018

dim closed D15733: Fix build of bxe with base gcc on i386.
Jun 11 2018, 10:08 AM
dim committed rS334948: Fix build of bxe with base gcc on i386.
Fix build of bxe with base gcc on i386
Jun 11 2018, 10:08 AM
dim created D15754: Fix build of liquidio with base gcc on i386.
Jun 11 2018, 8:49 AM
dim committed rS334947: Disable building aesni with base gcc.
Disable building aesni with base gcc
Jun 11 2018, 8:42 AM
dim updated the summary of D15753: Fix build of hyperv with base gcc on i386.
Jun 11 2018, 8:35 AM
dim created D15753: Fix build of hyperv with base gcc on i386.
Jun 11 2018, 8:32 AM
dim added a comment to D15752: Fix build of si with base gcc on i386.

Btw, this will be a direct commit to stable/11, since si was removed from head.

Jun 11 2018, 8:24 AM
dim created D15752: Fix build of si with base gcc on i386.
Jun 11 2018, 8:21 AM
dim closed D15744: Fix build of i915kms with base gcc.
Jun 11 2018, 8:11 AM
dim committed rS334946: Fix build of i915kms with base gcc.
Fix build of i915kms with base gcc
Jun 11 2018, 8:11 AM
dim committed rS334945: Fix build of ocs_fs with base gcc on i386.
Fix build of ocs_fs with base gcc on i386
Jun 11 2018, 7:57 AM
dim closed D15747: Fix build of ocs_fs with base gcc on i386.
Jun 11 2018, 7:57 AM

Jun 10 2018

dim created D15747: Fix build of ocs_fs with base gcc on i386.
Jun 10 2018, 8:41 PM
dim created D15746: Fix build of ndis with base gcc on i386.
Jun 10 2018, 8:29 PM
dim retitled D15744: Fix build of i915kms with base gcc from Fix build of i915kms with base gcc on i386 to Fix build of i915kms with base gcc.
Jun 10 2018, 8:14 PM
dim created D15744: Fix build of i915kms with base gcc.
Jun 10 2018, 8:14 PM
dim retitled D15725: Fix build of atk0110 with base gcc on i386 from Fix build of atk0110 with base gcc to Fix build of atk0110 with base gcc on i386.
Jun 10 2018, 8:17 AM
dim created D15733: Fix build of bxe with base gcc on i386.
Jun 10 2018, 8:17 AM
dim abandoned D15732: Fix build of bxe with base gcc on i386.
Jun 10 2018, 8:14 AM
dim created D15732: Fix build of bxe with base gcc on i386.
Jun 10 2018, 8:13 AM

Jun 9 2018

dim added inline comments to D15723: pmc gcc fixups.
Jun 9 2018, 9:18 PM
dim created D15725: Fix build of atk0110 with base gcc on i386.
Jun 9 2018, 9:07 PM
dim committed rS334886: Add missed libc++ entries to (Optional)ObsoleteFiles.inc.
Add missed libc++ entries to (Optional)ObsoleteFiles.inc
Jun 9 2018, 5:40 PM

Jun 7 2018

dim committed rS334771: MFC r334445:.
MFC r334445:
Jun 7 2018, 9:04 AM

Jun 3 2018

dim committed rS334572: MFC r334432:.
MFC r334432:
Jun 3 2018, 5:18 PM

May 31 2018

dim committed rS334445: Resolve conflicts between macros in fenv.h and ieeefp.h.
Resolve conflicts between macros in fenv.h and ieeefp.h
May 31 2018, 8:22 PM
dim closed D15633: Rename conflicting macros in fenv.h and ieeefp.h.
May 31 2018, 8:22 PM
dim updated the diff for D15633: Rename conflicting macros in fenv.h and ieeefp.h.

Completely revise approach, by letting lib/msun include <ieeefp.h>,
and defining all the common macros in the amd64 and i386 versions of
ieeefp.h instead. Those macros now use pointers as arguments, and
call sites have been updated.

May 31 2018, 7:34 PM
dim committed rS334432: Fix build of stand with base gcc.
Fix build of stand with base gcc
May 31 2018, 2:38 PM
dim closed D15628: Fix build of `stand/` with base gcc.
May 31 2018, 2:38 PM
dim added a comment to D15633: Rename conflicting macros in fenv.h and ieeefp.h.
In D15633#330244, @kib wrote:
In D15633#330243, @dim wrote:
In D15633#330225, @kib wrote:

Do arg-less macro conflict ? I think that no, and then there is no need to rename, use the __HAVE_MACRO_NAME trick to detect the presence of the macro in the namespace.

I don't think they do, but it's also more complicated to do it this way.

Why do you consider it more complicated ?

May 31 2018, 2:25 PM
dim added a comment to D15633: Rename conflicting macros in fenv.h and ieeefp.h.
In D15633#330225, @kib wrote:

Do arg-less macro conflict ? I think that no, and then there is no need to rename, use the __HAVE_MACRO_NAME trick to detect the presence of the macro in the namespace.

May 31 2018, 2:13 PM
dim updated the diff for D15628: Fix build of `stand/` with base gcc.

Re-uploading, with a few changes:

  • Removed the userboot changes, since rS334412 is a better fix
  • Use -Wno-unitialized with gcc 4.2.1 for cd9660read.c
  • Use -march=i386 instead of -mcpu=i386 in defs.mk. The gcc documentation states that -mcpu is a deprecated synonym for -mtune, but -mtune does not prevent instructions "higher" than i386, it merely tunes for them.
May 31 2018, 1:14 PM
dim created D15633: Rename conflicting macros in fenv.h and ieeefp.h.
May 31 2018, 11:51 AM

May 30 2018

dim accepted D15629: Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(.

LGTM now.

May 30 2018, 11:00 PM
dim added inline comments to D15628: Fix build of `stand/` with base gcc.
May 30 2018, 8:43 PM
dim added inline comments to D15628: Fix build of `stand/` with base gcc.
May 30 2018, 8:42 PM
dim created D15628: Fix build of `stand/` with base gcc.
May 30 2018, 8:23 PM

May 20 2018

dim committed rS333926: MFC r333715:.
MFC r333715:
May 20 2018, 4:03 PM

May 17 2018

dim committed rS333715: Pull in r322325 from upstream llvm trunk (by Matthias Braun):.
Pull in r322325 from upstream llvm trunk (by Matthias Braun):
May 17 2018, 2:39 PM

Apr 27 2018

dim committed rS333070: MFC r332833:.
MFC r332833:
Apr 27 2018, 7:22 PM

Apr 23 2018

dim committed rS332898: Pull in r329771 from upstream llvm trunk (by Craig Topper):.
Pull in r329771 from upstream llvm trunk (by Craig Topper):
Apr 23 2018, 11:08 PM

Apr 21 2018

dim committed rS332855: MFC r332414:.
MFC r332414:
Apr 21 2018, 9:58 AM

Apr 20 2018

dim committed rS332833: Recommit r332501, with an additional upstream fix for "Cannot lower.
Recommit r332501, with an additional upstream fix for "Cannot lower
Apr 20 2018, 6:21 PM

Apr 17 2018

dim accepted D15110: lld: add a __FreeBSD_version-style identifier to version.

LGTM

Apr 17 2018, 10:25 AM

Apr 14 2018

dim committed rS332503: Revert r332501 for now, as it can cause build failures on i386..
Revert r332501 for now, as it can cause build failures on i386.
Apr 14 2018, 2:57 PM
dim committed rS332501: Pull in r325446 from upstream clang trunk (by me):.
Pull in r325446 from upstream clang trunk (by me):
Apr 14 2018, 12:07 PM

Apr 11 2018

dim committed rS332414: Regenerate clang man page after upstream change to document the possible.
Regenerate clang man page after upstream change to document the possible
Apr 11 2018, 6:40 PM

Mar 31 2018

dim committed rD51525: Document __FreeBSD_version values:.
Document __FreeBSD_version values:
Mar 31 2018, 12:19 PM
dim committed rS331838: Merge clang, llvm, lld, lldb, compiler-rt and libc++ 6.0.0 release, and.
Merge clang, llvm, lld, lldb, compiler-rt and libc++ 6.0.0 release, and
Mar 31 2018, 11:43 AM

Mar 30 2018

dim added a comment to D4964: Protect calls to explicit_bzero() via by explicitly disabling the link-time and other optimizations that can cause code elimination..

@jim_netgate.com, does this trick work for both clang and gcc (both base and newer)? If so, I think this would be fine to commit. explicit_bzero could even be a macro! (And there might be a corresponding explicit_memset too, but I digress.)

Mar 30 2018, 12:26 AM

Mar 29 2018

dim committed rS331731: Pull in r328738 from upstream lld trunk (by Rafael Espindola):.
Pull in r328738 from upstream lld trunk (by Rafael Espindola):
Mar 29 2018, 1:55 PM

Mar 27 2018

dim committed rS331643: MFC r314568 (by emaste):.
MFC r314568 (by emaste):
Mar 27 2018, 6:53 PM

Mar 22 2018

dim committed rS331366: Pull in r327101 from upstream llvm trunk (by Rafael Espindola):.
Pull in r327101 from upstream llvm trunk (by Rafael Espindola):
Mar 22 2018, 6:58 PM

Mar 19 2018

dim abandoned D14720: Merge backported retpoline patches for clang 5.0.1.

This has been committed now.

Mar 19 2018, 6:39 PM

Mar 17 2018

dim committed rS331110: Follow-up to r331108 by also recording the reversal of r311861 in.
Follow-up to r331108 by also recording the reversal of r311861 in
Mar 17 2018, 8:17 PM
dim committed rS331108: Revert r330471 (MFC of r311861), since it results in compile errors.
Revert r330471 (MFC of r311861), since it results in compile errors
Mar 17 2018, 7:04 PM
dim committed rS331107: Repair obvious mismerge in r330897, resulting in misleading gcc error.
Repair obvious mismerge in r330897, resulting in misleading gcc error
Mar 17 2018, 6:56 PM
dim updated the diff for D14720: Merge backported retpoline patches for clang 5.0.1.

Remove auto-added Subversion properties.

Mar 17 2018, 2:18 PM
dim added a comment to D14720: Merge backported retpoline patches for clang 5.0.1.

IndirectBrExpandPass.cpp and X86RetpolineThunks.cpp have unintended SVN properties in the diff it seems

Mar 17 2018, 1:59 PM
dim created D14720: Merge backported retpoline patches for clang 5.0.1.
Mar 17 2018, 1:47 PM

Mar 16 2018

dim committed rS331066: Pull in r321999 from upstream clang trunk (by Ivan A. Kosarev):.
Pull in r321999 from upstream clang trunk (by Ivan A. Kosarev):
Mar 16 2018, 6:04 PM
dim committed rS331065: Pull in r327638 from upstream llvm trunk (by Matthew Simpson):.
Pull in r327638 from upstream llvm trunk (by Matthew Simpson):
Mar 16 2018, 5:51 PM

Mar 9 2018

dim committed rS330686: Pull in r326882 from upstream llvm trunk (by Sjoerd Meijer):.
Pull in r326882 from upstream llvm trunk (by Sjoerd Meijer):
Mar 9 2018, 9:21 AM

Mar 4 2018

dim committed rD51459: Document __FreeBSD_version value 1200060 (upgrading clang, llvm, lld,.
Document __FreeBSD_version value 1200060 (upgrading clang, llvm, lld,
Mar 4 2018, 5:11 PM
dim committed rS330384: Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to.
Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
Mar 4 2018, 5:06 PM
dim committed rS330376: Tag llvm 6.0.0 release r326565..
Tag llvm 6.0.0 release r326565.
Mar 4 2018, 3:30 PM
dim committed rS330378: Tag clang 6.0.0 release r326565..
Tag clang 6.0.0 release r326565.
Mar 4 2018, 3:27 PM
dim committed rS330380: Tag libc++ 6.0.0 release r326565..
Tag libc++ 6.0.0 release r326565.
Mar 4 2018, 3:21 PM
dim committed rS330383: Tag lldb 6.0.0 release r326565..
Tag lldb 6.0.0 release r326565.
Mar 4 2018, 3:20 PM
dim committed rS330379: Tag compiler-rt 6.0.0 release r326565..
Tag compiler-rt 6.0.0 release r326565.
Mar 4 2018, 3:14 PM