lld: add a __FreeBSD_version-style identifier to version

[emaste]

Summary

This adds a __FreeBSD_version style identifier as we have with __FreeBSD_cc_version for Clang, to facilitate WITH_SYSTEM_LINKER.

[emaste]

In upstream builds LLD_REPOSITORY_STRING and LLD_REVISION_STRING are populated by cmake, e.g. LLD 6.0.0 (http://llvm.org/git/lld 9c9fdd2152db0ff25594eee344f98a052f53b590) (compatible with GNU linkers).

[dim]

LGTM

[bdrewery]

Thanks, I'll get this added into my patch.

head/lib/clang/include/lld/Common/Version.inc

if (((sav->flags&SADB_X_EXT_OLD) == 0) ^ (sav->replay != NULL)) {
                 return EINVAL;
         }
         if (sav->key_auth == NULL) {
                 DPRINTF(("%s: no authentication key for %s algorithm\n",
                         __func__, thash->name));
                 return EINVAL;
         }
         keylen = _KEYLEN(sav->key_auth);
-        if (keylen != thash->keysize && thash->keysize != 0) {
+        if (keylen > thash->keysize && thash->keysize != 0) {
                 DPRINTF(("%s: invalid keylength %d, algorithm %s requires "
-                        "keysize %d\n", __func__,
+                        "keysize less than %d\n", __func__,
                          keylen, thash->name, thash->keysize));
                 return EINVAL;
         }
 
         sav->tdb_xform = xsp;
         sav->tdb_authalgxform = thash;
 
         /* Initialize crypto session. */