Page MenuHomeFreeBSD

Fix build of bxe with base gcc on i386
ClosedPublic

Authored by dim on Jun 10 2018, 8:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 21, 4:50 AM
Unknown Object (File)
Mon, Sep 15, 11:56 AM
Unknown Object (File)
Sep 4 2025, 3:03 PM
Unknown Object (File)
Sep 4 2025, 10:28 AM
Unknown Object (File)
Sep 4 2025, 9:50 AM
Unknown Object (File)
Jun 28 2025, 7:04 PM
Unknown Object (File)
Jun 27 2025, 5:52 AM
Unknown Object (File)
Jun 27 2025, 4:10 AM
Subscribers

Details

Summary

Base gcc fails to compile sys/dev/bxe/bxe.c for i386, with the
following -Werror warnings:

cc1: warnings being treated as errors
/usr/src/sys/dev/bxe/bxe.c: In function 'bxe_allocate_bars':
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This is because on i386, the casts from rman_res_t (aka uintmax_t)
to a pointer reduces the value from 64 bit to 32 bit, and similar for
the kva member of struct bxe_bar, which is a vm_offset_t (aka
uint32_t).

For gcc, this can be fixed by an intermediate cast to uintptr_t. Note
that I am assuming the incoming values will always fit into 32 bit!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 10 2018, 2:07 PM

64bit BARs can have addresses and lengths bigger than 32bits, so I would rather cast to uint64_t and use PRIx64 in order to print them. Or cast to uintmax_t and print with PRIxMAX.

This revision was automatically updated to reflect the committed changes.