Page MenuHomeFreeBSD

Fix build of bxe with base gcc on i386
AbandonedPublic

Authored by dim on Jun 10 2018, 8:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 25 2024, 10:28 PM
Unknown Object (File)
Mar 2 2024, 4:37 PM
Unknown Object (File)
Dec 20 2023, 8:36 AM
Subscribers

Details

Reviewers
None
Summary

Base gcc fails to compile sys/dev/bxe/bxe.c for i386, with the
following -Werror warnings:

cc1: warnings being treated as errors
/usr/src/sys/dev/bxe/bxe.c: In function 'bxe_allocate_bars':
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/bxe/bxe.c:12822: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This is because on i386, the casts from rman_res_t (aka uintmax_t)
to a pointer reduces the value from 64 bit to 32 bit, and similar for
the kva member of struct bxe_bar, which is a vm_offset_t (aka
uint32_t).

For gcc, this can be fixed by an intermediate cast to intptr_t. Note
that I am assuming the incoming arg2 will always fit into 32 bit!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17131
Build 16986: arc lint + arc unit