Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(
ClosedPublic
Actions

Authored by imp on May 30 2018, 8:59 PM.

Tags

None

Referenced Files

	F166679196: D15629.id43189.diff
	Sat, Aug 15, 11:59 AM

	F166678628: D15629.id43176.diff
	Sat, Aug 15, 11:52 AM

	F166678496: D15629.id43177.diff
	Sat, Aug 15, 11:50 AM

	F166677486: D15629.diff
	Sat, Aug 15, 11:41 AM

	Unknown Object (File)
	Wed, Aug 12, 11:03 AM

	Unknown Object (File)
	Tue, Aug 11, 7:10 AM

	Unknown Object (File)
	Tue, Aug 11, 3:03 AM

	Unknown Object (File)
	Sun, Aug 9, 10:07 PM

View All Files

Subscribers

None

Details

Reviewers

rgrimes
dim
kevans
emaste

Group Reviewers

bhyve

Commits

rS334415: Update to device enumeration protocol 2
rS334414: Make the data returned by devinfo harder to overflow.
rS334413: Sanity check the return from the kernel.
rS334412: Pass a struct devdesc to the format commands. Use proper type rather

Summary

This is a fix for an issue found during https://reviews.freebsd.org/D15628

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.May 30 2018, 8:59 PM

Herald added a reviewer: rgrimes. · View Herald TranscriptMay 30 2018, 8:59 PM

Harbormaster completed remote builds in B16932: Diff 43176.May 30 2018, 8:59 PM

update.

Harbormaster completed remote builds in B16933: Diff 43177.May 30 2018, 9:05 PM

Copy over subscribers from D15628 and describe this review as a fix for an issue found during that review.

LGTM now.

This revision is now accepted and ready to land.May 30 2018, 11:00 PM

Closed by commit rS334412: Pass a struct devdesc to the format commands. Use proper type rather (authored by imp). · Explain WhyMay 31 2018, 2:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

userboot/

devicename.c

10 lines

main.c

17 lines

Diff 43189

View Options

head/stand/userboot/userboot/devicename.c