Page MenuHomeFreeBSD

Clang: Only build needed target for bootstrap compiler.
ClosedPublic

Authored by bdrewery on Jun 26 2018, 6:18 PM.

Details

Summary

This will disable the new LLVM_TARGET_ALL option which will only
enable the required target.

This only impacts the bootstrap compiler in WORLDTMP, not the target compiler
that will be installed.

Sponsored by: Dell EMC

Test Plan

Did buildworld with native arch, cross-arch, and testing of the universe-one-clang patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Jun 26 2018, 7:19 PM

Isn't WITH_LLVM_TARGET_ALL the default, and if so, shouldn't WITHOUT_LLVM_TARGET_ALL be documented instead? (I always found these explanatory files a little confusing, though...)

Oh, I just saw the WITHOUT_ file was added in your other review.

Allow overriding MK_LLVM_TARGET_ALL (for one-clang-universe)

This revision now requires review to proceed.Jun 27 2018, 4:47 PM
In D16021#339386, @dim wrote:

Oh, I just saw the WITHOUT_ file was added in your other review.

Yeah this review is just utilizing the feature for buildworld. The other adds the option as a simpler means to enable/disable unneeded targets for users.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2018, 4:58 PM
This revision was automatically updated to reflect the committed changes.