Clang: Only build needed target for bootstrap compiler.
ClosedPublic
Actions

Authored by bdrewery on Jun 26 2018, 6:18 PM.

Details

Reviewers

imp
emaste
dim
brooks
sbruno

Commits

rS335707: Clang: Only build needed target for bootstrap compiler.

Summary

This will disable the new LLVM_TARGET_ALL option which will only
enable the required target.

This only impacts the bootstrap compiler in WORLDTMP, not the target compiler
that will be installed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery created this revision.Jun 26 2018, 6:18 PM

Harbormaster completed remote builds in B17633: Diff 44475.Jun 26 2018, 6:18 PM

bdrewery added a parent revision: D16020: Add LLVM_TARGET_ALL option..Jun 26 2018, 6:19 PM

bdrewery added a subscriber: sbruno.

sbruno accepted this revision.Jun 26 2018, 7:19 PM

This revision is now accepted and ready to land.Jun 26 2018, 7:19 PM

Isn't WITH_LLVM_TARGET_ALL the default, and if so, shouldn't WITHOUT_LLVM_TARGET_ALL be documented instead? (I always found these explanatory files a little confusing, though...)

Oh, I just saw the WITHOUT_ file was added in your other review.

Allow overriding MK_LLVM_TARGET_ALL (for one-clang-universe)

This revision now requires review to proceed.Jun 27 2018, 4:47 PM

Harbormaster completed remote builds in B17670: Diff 44534.Jun 27 2018, 4:47 PM

In D16021#339386, @dim wrote:

Oh, I just saw the WITHOUT_ file was added in your other review.

Yeah this review is just utilizing the feature for buildworld. The other adds the option as a simpler means to enable/disable unneeded targets for users.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2018, 4:58 PM

Closed by commit rS335707: Clang: Only build needed target for bootstrap compiler. (authored by bdrewery). · Explain Why

This revision was automatically updated to reflect the committed changes.