Page MenuHomeFreeBSD
Differential D16018

Use dependent options to auto enable _SUPPORT and CLANG_FULL options.
ClosedPublic
Actions

Authored by bdrewery on Jun 26 2018, 6:17 PM.
Tags
None
Referenced Files
F146956667: D16018.diff
Sat, Mar 7, 2:57 AM
Unknown Object (File)
Thu, Mar 5, 1:57 PM
Unknown Object (File)
Thu, Mar 5, 12:02 PM
Unknown Object (File)
Thu, Mar 5, 7:02 AM
Unknown Object (File)
Thu, Mar 5, 6:21 AM
Unknown Object (File)
Wed, Mar 4, 10:31 PM
Unknown Object (File)
Tue, Mar 3, 5:58 PM
Unknown Object (File)
Sun, Feb 8, 3:08 AM
View All 96 Files
Subscribers
None

Details

Reviewers
imp
dim
emaste
brooks
sbruno
Commits
rS335705: Use dependent options to auto enable _SUPPORT and CLANG_FULL options.
Summary

Sponsored by: Dell EMC

Test Plan

various make showconfig combinations

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery created this revision.Jun 26 2018, 6:17 PM
Harbormaster completed remote builds in B17631: Diff 44473.Jun 26 2018, 6:17 PM
bdrewery added a child revision: D16020: Add LLVM_TARGET_ALL option..Jun 26 2018, 6:18 PM
bdrewery edited the test plan for this revision. (Show Details)
sbruno accepted this revision.Jun 26 2018, 7:18 PM
This revision is now accepted and ready to land.Jun 26 2018, 7:18 PM
dim accepted this revision.Jun 26 2018, 11:21 PM

LGTM. What's the difference between e.g. MK_BLACKLIST and MK_BLACKLIST_SUPPORT, btw?

bdrewery added a comment.Jun 27 2018, 4:51 PM
In D16018#339388, @dim wrote:

LGTM. What's the difference between e.g. MK_BLACKLIST and MK_BLACKLIST_SUPPORT, btw?

Used differently but I didn't look into why...

etc/Makefile:.if ${MK_BLACKLIST} != "no"
etc/rc.d/Makefile:.if ${MK_BLACKLIST} != "no"
lib/Makefile:SUBDIR.${MK_BLACKLIST}+=libblacklist
libexec/Makefile:.if ${MK_BLACKLIST} != "no"
libexec/fingerd/Makefile:.if ${MK_BLACKLIST_SUPPORT} != "no"
libexec/ftpd/Makefile:.if ${MK_BLACKLIST_SUPPORT} != "no"
secure/usr.sbin/sshd/Makefile:.if ${MK_BLACKLIST_SUPPORT} != "no"
share/mk/src.libnames.mk:.if ${MK_BLACKLIST} != "no"
share/mk/src.libnames.mk:.if ${MK_BLACKLIST} != "no"
targets/pseudo/userland/Makefile.depend:.if ${MK_BLACKLIST_SUPPORT} != "no"
targets/pseudo/userland/lib/Makefile.depend:.if ${MK_BLACKLIST_SUPPORT} != "no"
targets/pseudo/userland/libexec/Makefile.depend:.if ${MK_BLACKLIST_SUPPORT} != "no"
tools/build/mk/OptionalObsoleteFiles.inc:.if ${MK_BLACKLIST} == no
usr.sbin/Makefile:SUBDIR.${MK_BLACKLIST}+=      blacklistctl
usr.sbin/Makefile:SUBDIR.${MK_BLACKLIST}+=      blacklistd
Closed by commit rS335705: Use dependent options to auto enable _SUPPORT and CLANG_FULL options. (authored by bdrewery). · Explain WhyJun 27 2018, 4:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
share/
mk/
49 lines

Diff 44538

View Options

head/share/mk/src.opts.mk

Loading...