If this needs additional time, would you mind if I integrate part of your change (arc4random_buf) for now?

Looks good to me.

In D10048#208539, @markm wrote:

I'm not comfortable with critical sections for now. Back to mutexes
as before. I'm happy to revisit this later.

Could you please also address https://reviews.freebsd.org/D10048?id=26438#inline-59236 ?

Could you please take a look at the arc4rand() portion of my comment?

LGTM overall but please consider using explicit_bzero when removing sensitive data from memory.

Copy avail_ssize, adj_free and max_free.

Please do not commit as-is.

I think this is good in principle (I have commented inline for the ones that doesn't really matter, but the changes would not hurt either), so no objection here. Please consider waiting for a few more days to see if Pawel have any objections.

Add maintainer. (I think this should be upstreamed?)

Thanks!

Please include the URL reference for the quoted information too.

In D9606#198577, @pkelsey wrote:

This makes sense to me from the standpoint of the removed code being unnecessary given that it is being maintained as part of a version of libpcap that doesn't require it.

Are updates to this file periodically, or even at-some-point-theoretically, merged in from an upstream netmap repo? If so, removing this code locally would create an additional maintenance burden for us later, and maybe then removing it isn't worth it as it is otherwise harmless.