Don't leak a session and lock if a GMAC key has an invalid length.
ClosedPublic
Actions

Authored by jhb on Apr 4 2017, 4:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 9, 4:58 PM

	Unknown Object (File)
	Tue, Sep 30, 10:37 AM

	Unknown Object (File)
	Mon, Sep 29, 11:49 AM

	Unknown Object (File)
	Sun, Sep 28, 5:06 PM

	Unknown Object (File)
	Sun, Sep 28, 4:52 PM

	Unknown Object (File)
	Wed, Sep 17, 1:51 PM

	Unknown Object (File)
	Fri, Sep 12, 9:06 AM

	Unknown Object (File)
	Sep 7 2025, 5:54 AM

View All Files

Subscribers

delphij

imp

Details

Reviewers

jmg
delphij

Group Reviewers

secteam

Commits

rS316510: Don't leak a session and lock if a GMAC key has an invalid length.

Test Plan

Run a buggy gcm test that did not set the hash key only the cipher key (so the hash key length was 0). Observe panic on return to userland due to leaked lock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 4 2017, 4:33 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 4 2017, 4:33 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 4 2017, 5:06 PM

Harbormaster completed remote builds in B8498: Diff 27040.Apr 4 2017, 5:18 PM

Closed by commit rS316510: Don't leak a session and lock if a GMAC key has an invalid length. (authored by jhb). · Explain WhyApr 5 2017, 1:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

cryptosoft.c

5 lines

Diff 27070

View Options

head/sys/opencrypto/cryptosoft.c

Don't leak a session and lock if a GMAC key has an invalid length.ClosedPublicActions