Page MenuHomeFreeBSD
Differential D10273

Don't leak a session and lock if a GMAC key has an invalid length.
ClosedPublic
Actions

Authored by jhb on Apr 4 2017, 4:33 PM.
Tags
None
Referenced Files
F134596092: D10273.id27070.diff
Mon, Nov 3, 12:26 PM
F134596074: D10273.id27040.diff
Mon, Nov 3, 12:26 PM
F134595931: D10273.id.diff
Mon, Nov 3, 12:25 PM
F134595651: D10273.diff
Mon, Nov 3, 12:23 PM
Unknown Object (File)
Sun, Nov 2, 11:13 AM
Unknown Object (File)
Mon, Oct 20, 6:35 PM
Unknown Object (File)
Mon, Oct 20, 6:35 PM
Unknown Object (File)
Mon, Oct 20, 6:35 PM
View All Files
Subscribers
delphij
imp

Details

Reviewers
jmg
delphij
Group Reviewers
secteam
Commits
rS316510: Don't leak a session and lock if a GMAC key has an invalid length.
Test Plan
  • Run a buggy gcm test that did not set the hash key only the cipher key (so the hash key length was 0). Observe panic on return to userland due to leaked lock.

Diff Detail

Event Timeline

jhb created this revision.Apr 4 2017, 4:33 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 4 2017, 4:33 PM
delphij accepted this revision.Apr 4 2017, 5:06 PM
delphij added a subscriber: delphij.

Looks good to me.

This revision is now accepted and ready to land.Apr 4 2017, 5:06 PM
Harbormaster completed remote builds in B8498: Diff 27040.Apr 4 2017, 5:18 PM
Closed by commit rS316510: Don't leak a session and lock if a GMAC key has an invalid length. (authored by jhb). · Explain WhyApr 5 2017, 1:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
opencrypto/
5 lines

Diff 27040

View Options

sys/opencrypto/cryptosoft.c

Loading...