Page MenuHomeFreeBSD
Differential D4827

sed: Use S_ISREG.
ClosedPublic
Actions

Authored by delphij on Jan 8 2016, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 21 2024, 5:30 AM
Unknown Object (File)
Dec 22 2023, 10:18 AM
Unknown Object (File)
Oct 19 2023, 7:25 PM
Unknown Object (File)
Oct 19 2023, 5:41 PM
Unknown Object (File)
Aug 17 2023, 2:42 AM
Unknown Object (File)
Aug 15 2023, 3:15 AM
Unknown Object (File)
Jun 16 2023, 9:30 AM
Unknown Object (File)
Jun 3 2023, 5:23 PM
View All 38 Files
Subscribers
antoine
imp

Details

Reviewers
des
Commits
rS313277: Restore r312404:
rS312404: Use S_ISREG instead of manual & (also it's better to compare the
Summary

Use S_ISREG instead of manual & (also it's better to compare the
result from & and the pattern instead of just assuming it's one bit
value).

Pointed out by Tianjie Mao <tjmao tjmao com>.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

delphij updated this revision to Diff 12037.Jan 8 2016, 6:33 AM
delphij retitled this revision from to Use S_ISREG..
delphij updated this object.
delphij edited the test plan for this revision. (Show Details)
delphij added a reviewer: des.
Herald added a subscriber: imp. · View Herald TranscriptJan 8 2016, 6:33 AM
delphij retitled this revision from Use S_ISREG. to sed: Use S_ISREG..Jan 8 2016, 6:34 AM
Closed by commit rS312404: Use S_ISREG instead of manual & (also it's better to compare the (authored by delphij). · Explain WhyJan 19 2017, 8:01 AM
This revision was automatically updated to reflect the committed changes.
antoine added a subscriber: antoine.Jan 20 2017, 6:38 AM

This change breaks sed -i on symlinks which breaks lots of ports.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
sed/
2 lines

Diff 24187

View Options

head/usr.bin/sed/main.c

Loading...