Differential D4827

sed: Use S_ISREG.
ClosedPublic
Actions

Authored by delphij on Jan 8 2016, 6:33 AM.

Tags

None

Referenced Files

	F172841564: D4827.id.diff
	Mon, Sep 21, 12:03 PM

	Unknown Object (File)
	Fri, Sep 18, 7:29 PM

	Unknown Object (File)
	Thu, Sep 17, 10:42 PM

	Unknown Object (File)
	Sun, Sep 13, 6:24 AM

	Unknown Object (File)
	Fri, Sep 11, 11:59 PM

	Unknown Object (File)
	Fri, Sep 11, 7:09 PM

	Unknown Object (File)
	Fri, Sep 11, 4:20 AM

	Unknown Object (File)
	Thu, Sep 10, 1:03 PM

Subscribers

Details

Reviewers

Commits

rGc8828fec0540: TCP BBR: remove code which is never executed
rG8a246cebc105: TCP BBR: remove code which is never executed
rG1781324db2bc: TCP BBR: remove code which is never executed
rS313277: Restore r312404:
rS312404: Use S_ISREG instead of manual & (also it's better to compare the

Summary

Use S_ISREG instead of manual & (also it's better to compare the
result from & and the pattern instead of just assuming it's one bit
value).

Pointed out by Tianjie Mao <tjmao tjmao com>.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij updated this revision to Diff 12037.Jan 8 2016, 6:33 AM

delphij retitled this revision from to Use S_ISREG..

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added a reviewer: des.

Herald added a subscriber: imp. · View Herald TranscriptJan 8 2016, 6:33 AM

delphij retitled this revision from Use S_ISREG. to sed: Use S_ISREG..Jan 8 2016, 6:34 AM

Closed by commit rS312404: Use S_ISREG instead of manual & (also it's better to compare the (authored by delphij). · Explain WhyJan 19 2017, 8:01 AM

This revision was automatically updated to reflect the committed changes.

This change breaks sed -i on symlinks which breaks lots of ports.

tuexen added a commit: rG1781324db2bc: TCP BBR: remove code which is never executed.Jan 1 2025, 5:42 PM

tuexen added a commit: rG8a246cebc105: TCP BBR: remove code which is never executed.Feb 5 2025, 8:32 PM

tuexen added a commit: rGc8828fec0540: TCP BBR: remove code which is never executed.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

sed/

2 lines

Diff 24187

head/usr.bin/sed/main.c

Loading...