Page MenuHomeFreeBSD

Fix memory leak in openssh
Needs ReviewPublic

Authored by trix_juniper.net on Feb 24 2017, 6:10 PM.

Details

Summary

packet.c ssh_packet_read_seqnr
Change the error handling of SSH_ERR_CON_TIMEOUT to be consistent with the other error handling. This fixes a memory leak with setp.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problem, run scan-build after to show the problem is resolved.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

trix_juniper.net retitled this revision from to Fix memory leak in openssh.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net set the repository for this revision to rS FreeBSD src repository.
lidl edited edge metadata.Feb 25 2017, 5:01 PM

I forwarded this diff to 'des' (who doesn't use phabricator).

His suggestion that this bug ought to be forwarded upstream, to
the openssh maintainers, and we can pickup the fix from them.

(No debate that there's a memory leak, just a different manner of
getting the fix into FreeBSD.)

Ok, i will get this upstreamed.

delphij added a reviewer: des.Feb 27 2017, 5:13 AM

Add maintainer. (I think this should be upstreamed?)