Page MenuHomeFreeBSD

Fix memory leak in openssh
ClosedPublic

Authored by emaste on Feb 24 2017, 6:10 PM.

Details

Summary

packet.c ssh_packet_read_seqnr
Change the error handling of SSH_ERR_CON_TIMEOUT to be consistent with the other error handling. This fixes a memory leak with setp.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problem, run scan-build after to show the problem is resolved.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

trix_juniper.net retitled this revision from to Fix memory leak in openssh.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

I forwarded this diff to 'des' (who doesn't use phabricator).

His suggestion that this bug ought to be forwarded upstream, to
the openssh maintainers, and we can pickup the fix from them.

(No debate that there's a memory leak, just a different manner of
getting the fix into FreeBSD.)

Add maintainer. (I think this should be upstreamed?)

emaste accepted this revision.
emaste added a reviewer: trix_juniper.net.
This revision is now accepted and ready to land.Apr 12 2022, 1:54 PM