packet.c ssh_packet_read_seqnr
Change the error handling of SSH_ERR_CON_TIMEOUT to be consistent with the other error handling. This fixes a memory leak with setp.
Details
Details
Run clang's static analyzer, scan-build, before to reproduce the problem, run scan-build after to show the problem is resolved.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I forwarded this diff to 'des' (who doesn't use phabricator).
His suggestion that this bug ought to be forwarded upstream, to
the openssh maintainers, and we can pickup the fix from them.
(No debate that there's a memory leak, just a different manner of
getting the fix into FreeBSD.)
Comment Actions
I have submitted bug reports to openssh here
https://bugzilla.mindrot.org/show_bug.cgi?id=2683
https://bugzilla.mindrot.org/show_bug.cgi?id=2684