Page MenuHomeFreeBSD

ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex
ClosedPublic

Authored by glebius on Dec 4 2021, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 6:37 PM
Unknown Object (File)
Jan 31 2024, 11:25 AM
Unknown Object (File)
Dec 11 2023, 11:39 PM
Unknown Object (File)
Dec 4 2023, 8:48 PM
Unknown Object (File)
Nov 28 2023, 4:00 AM
Unknown Object (File)
Nov 25 2023, 4:36 AM
Unknown Object (File)
Nov 22 2023, 8:39 PM
Unknown Object (File)
Nov 22 2023, 5:17 PM
Subscribers

Details

Summary

The lockless access to the array is protected by the network epoch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think there should only be one function for "store" pointer which is ifnet_setbyindex(); that'll be possible if you consider my comment from D33259; though in the longer term it probably won't matter to have the other one for ifindex_free() as we'd still guarantee that all accesses go through wrapper functions so we can keep changing the internals.

If you can explain the added WASSERT I am fine with this.

sys/net/if.c
416

Contrary to your description, why do you need to add this suddenly here?

sys/net/if.c
416

Can be removed, but it still removed when all index allocation bits are merged into one in D33262

This revision is now accepted and ready to land.Dec 6 2021, 10:48 AM