malloc(9): Document/add aligned variants
ClosedPublic
Actions

Authored by adam_fenn.io on Jul 2 2021, 9:27 PM.

Details

Reviewers

kib
royger
imp

Group Reviewers

manpages

Commits

rG6162cf885c00: malloc(9): Document/complete aligned variants

Summary

As per https://reviews.freebsd.org/D29733#696995 and https://reviews.freebsd.org/D29733#696995, introduce malloc_aligned() and add this and malloc_domainset_aligned() to malloc(9).

Test Plan

Tested via a version of https://reviews.freebsd.org/differential/diff/91630/ with the following modification in kvm_clock_attach():

-	sc->timeinfos = malloc_domainset_aligned(round_page(mp_ncpus *
+	sc->timeinfos = malloc_aligned(round_page(mp_ncpus *
 	    sizeof(struct pvclock_vcpu_time_info)), PAGE_SIZE, M_DEVBUF,
-	    DOMAINSET_RR(), M_WAITOK | M_ZERO);
+	    M_WAITOK | M_ZERO);

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40245
Build 37134: arc lint + arc unit

Event Timeline

adam_fenn.io created this revision.Jul 2 2021, 9:27 PM

adam_fenn.io held this revision as a draft.

Herald added a reviewer: manpages. · View Herald TranscriptJul 2 2021, 9:27 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B40245: Diff 91679.Jul 2 2021, 9:27 PM

adam_fenn.io edited the test plan for this revision. (Show Details)Jul 2 2021, 9:32 PM

adam_fenn.io published this revision for review.Jul 2 2021, 9:35 PM

kib added inline comments.Jul 2 2021, 10:03 PM

share/man/man9/malloc.9
74	You can use .Fo to avoid this long line
99	It would be useful to note that: align should be non-zero and power of two we only support align requests less or equal to the page size