Differential D28880

bhyve: Use fspacectl(2) for BOP_DELETE on regular file images
ClosedPublic
Actions

Authored by khng on Feb 23 2021, 6:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 8, 6:59 PM

	Unknown Object (File)
	Mon, May 5, 6:01 PM

	Unknown Object (File)
	Sun, May 4, 10:16 PM

	Unknown Object (File)
	Sat, May 3, 11:56 PM

	Unknown Object (File)
	Wed, Apr 23, 7:47 AM

	Unknown Object (File)
	Mon, Apr 21, 2:50 AM

	Unknown Object (File)
	Mar 31 2025, 12:04 PM

	Unknown Object (File)
	Mar 22 2025, 11:40 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Commits

rG3676512b60d6: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images

Summary

bhyve can also make use of fspacectl(2) to implement BOP_DELETE with
hole-punching. Since it is not desirable to do zero-filling for large
DEALLOCATE/UNMAP range, candelete is not set if pathconf(2) indicates
that the underlying file system does not support native
VOP_DEALLOCATE(9).

Submitted by: Ka Ho Ng <khng@freebsdfoundation.org>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37926
Build 34815: arc lint + arc unit

Event Timeline

khng created this revision.Feb 23 2021, 6:43 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 23 2021, 6:43 AM

Herald added subscribers: Contributor Reviews (src), bcran, rgrimes, imp. · View Herald Transcript

khng requested review of this revision.Feb 23 2021, 6:43 AM

khng added a parent revision: D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Feb 23 2021, 6:44 AM

Harbormaster completed remote builds in B37292: Diff 84515.Feb 23 2021, 6:44 AM

lwhsu added a subscriber: lwhsu.Feb 23 2021, 7:02 AM

Updated commit message.

Harbormaster completed remote builds in B37315: Diff 84554.Feb 23 2021, 3:21 PM

khng edited the summary of this revision. (Show Details)Feb 23 2021, 3:22 PM

Rebased.

Harbormaster completed remote builds in B37398: Diff 84733.Feb 26 2021, 8:14 AM

Rebased.

Harbormaster completed remote builds in B37926: Diff 85985.Mar 18 2021, 7:51 PM

Rebased

Harbormaster completed remote builds in B37942: Diff 86011.Mar 19 2021, 8:40 AM

Updated commit message.

Harbormaster completed remote builds in B38009: Diff 86186.Mar 23 2021, 10:13 AM

Bump due to updates of D28347 (fspacectl(2) added new param)

Harbormaster completed remote builds in B40793: Diff 93087.Aug 1 2021, 9:22 PM

grehan accepted this revision.Aug 5 2021, 11:30 PM

This revision is now accepted and ready to land.Aug 5 2021, 11:30 PM

Loop over to guarantee the whole region is finished.

This revision now requires review to proceed.Aug 7 2021, 8:13 AM

Harbormaster completed remote builds in B40914: Diff 93365.Aug 7 2021, 8:13 AM

grehan accepted this revision.Aug 7 2021, 8:49 AM

This revision is now accepted and ready to land.Aug 7 2021, 8:49 AM

Closed by commit rG3676512b60d6: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images (authored by khng). · Explain WhyAug 7 2021, 9:12 AM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rG3676512b60d6: bhyve: Use fspacectl(2) for BOP_DELETE on regular file images.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

17 lines

Diff 85985

usr.sbin/bhyve/block_if.c

Loading...