Differential D29190

pf: Simplify cleanup
ClosedPublic
Actions

Authored by kp on Mar 10 2021, 3:42 PM.

Details

Reviewers

None

Group Reviewers

network

Commits

rGf858f6b2381c: pf: Simplify cleanup
rG4ed78443da29: pf: Simplify cleanup
rG28dc2c954f50: pf: Simplify cleanup

Summary

We can now counter_u64_free(NULL), so remove the checks.

MFC after: 1 week
Sponsored-by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37731
Build 34620: arc lint + arc unit

Event Timeline

kp created this revision.Mar 10 2021, 3:42 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMar 10 2021, 3:42 PM

kp requested review of this revision.Mar 10 2021, 3:42 PM

Harbormaster completed remote builds in B37731: Diff 85486.Mar 10 2021, 3:42 PM

Can counter ptr really be NULL is these cases? If yes, I'd rather retain the existing checks as they indicate that this a valid possibility.

Also, counter(9) man page says nothing about the free(NULL) use case.

In D29190#653630, @melifaro wrote:

Can counter ptr really be NULL is these cases? If yes, I'd rather retain the existing checks as they indicate that this a valid possibility.

It can happen, but really only if we fail to allocate memory (see line 520-521).

Also, counter(9) man page says nothing about the free(NULL) use case.

Until D29189 it couldn't handle that. This commit builds on top of that.

In D29190#653711, @kp wrote:

Until D29189 it couldn't handle that. This commit builds on top of that.

May you please stack them together to make this dependency explicit?

kp added a parent revision: D29189: uma: allow uma_zfree_pcu(..., NULL).Mar 11 2021, 7:56 AM

In D29190#653711, @kp wrote:

In D29190#653630, @melifaro wrote:

Can counter ptr really be NULL is these cases? If yes, I'd rather retain the existing checks as they indicate that this a valid possibility.

It can happen, but really only if we fail to allocate memory (see line 520-521).

Also, counter(9) man page says nothing about the free(NULL) use case.

Until D29189 it couldn't handle that. This commit builds on top of that.