Paths

Table of Contentst

Differential D29116

Flush remaining routes from the routing table during VNET shutdown.
ClosedPublic
Actions

Authored by melifaro on Mar 7 2021, 6:38 PM.

Tags

None

Referenced Files

	F122599087: D29116.id85301.diff
	Sun, Jul 6, 2:23 PM

	Unknown Object (File)
	Thu, Jun 26, 4:30 AM

	Unknown Object (File)
	Thu, Jun 26, 1:53 AM

	Unknown Object (File)
	Fri, Jun 20, 2:11 AM

	Unknown Object (File)
	Mon, Jun 16, 5:42 PM

	Unknown Object (File)
	Sun, Jun 15, 9:24 AM

	Unknown Object (File)
	Thu, Jun 12, 12:28 PM

	Unknown Object (File)
	Wed, Jun 11, 6:42 AM

Subscribers

Details

Reviewers

kp
bz

Group Reviewers

Commits

rG6f4f8a441aaa: Flush remaining routes from the routing table during VNET shutdown.
rG8aafa7a02763: Flush remaining routes from the routing table during VNET shutdown.
rGb1d63265ac39: Flush remaining routes from the routing table during VNET shutdown.

Summary

This fixes rtentry leak for the cloned interfaces created inside the
VNET.

PR: 253998
Reported by: rashey at superbox.pl
MFC after: 3 days

Current code cleans up protocol state in ip[6]_destroy(). It includes flushing route entries on a per-interface basis using rt_flushifroutes_af(). The latter function removes all interface routes except ones with RTF_PINNED flag (e.g. interface routes).
As a result, some of the rtentries may leak.

Add rib_flush_routes_af() which removes all of the routes for the specified family in a light-weight fashion and switch IPv4/IPv6 stack teardown to use it instead of iterating over all interfaces with rt_flushroutes_af().

Test Plan

# kyua test -k /usr/tests/sys/netpfil/pf/Kyuafile set_skip:set_skip_group_lo
set_skip:set_skip_group_lo  ->  passed  [0.053s]
tail -n 200 /var/log/messages | grep rtentry
#

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37685
Build 34574: arc lint + arc unit

Event Timeline

melifaro created this revision.Mar 7 2021, 6:38 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMar 7 2021, 6:38 PM

melifaro requested review of this revision.Mar 7 2021, 6:38 PM

Harbormaster completed remote builds in B37658: Diff 85301.Mar 7 2021, 6:38 PM

melifaro edited the summary of this revision. (Show Details)Mar 7 2021, 6:51 PM

melifaro edited the test plan for this revision. (Show Details)

kp accepted this revision as: kp.Mar 8 2021, 10:37 AM

This revision is now accepted and ready to land.Mar 8 2021, 10:37 AM

Implement a cleaner fix.

This revision now requires review to proceed.Mar 8 2021, 11:21 PM

Harbormaster completed remote builds in B37685: Diff 85362.Mar 8 2021, 11:21 PM

melifaro edited the summary of this revision. (Show Details)Mar 9 2021, 8:07 AM

kp accepted this revision as: kp.Mar 9 2021, 10:51 AM

This revision is now accepted and ready to land.Mar 9 2021, 10:51 AM

Closed by commit rGb1d63265ac39: Flush remaining routes from the routing table during VNET shutdown. (authored by melifaro). · Explain WhyMar 10 2021, 9:29 PM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGb1d63265ac39: Flush remaining routes from the routing table during VNET shutdown..

melifaro added a commit: rG8aafa7a02763: Flush remaining routes from the routing table during VNET shutdown..Mar 13 2021, 8:26 PM

melifaro added a commit: rG6f4f8a441aaa: Flush remaining routes from the routing table during VNET shutdown..Mar 28 2021, 8:50 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

2 lines

15 lines

route/

36 lines

netinet/

6 lines

netinet6/

5 lines

Diff 85362

sys/net/route.h

Loading...

sys/net/route.c

Loading...

sys/net/route/route_ctl.c

Loading...

sys/netinet/ip_input.c

Loading...

sys/netinet6/ip6_input.c

Loading...