Page MenuHomeFreeBSD
Differential D28833

Implement posix_fallocate(2) by fo_fspacectl.
Needs ReviewPublic
Actions

Authored by khng on Feb 21 2021, 8:33 AM.
Tags
None
Referenced Files
F150444368: D28833.id87466.diff
Wed, Apr 1, 6:30 AM
F150444211: D28833.id84404.diff
Wed, Apr 1, 6:28 AM
F150442352: D28833.id86185.diff
Wed, Apr 1, 6:12 AM
F150442209: D28833.id87536.diff
Wed, Apr 1, 6:10 AM
F150441842: D28833.id84732.diff
Wed, Apr 1, 6:07 AM
F150439401: D28833.id85988.diff
Wed, Apr 1, 5:46 AM
F150434049: D28833.id85107.diff
Wed, Apr 1, 5:03 AM
F150433971: D28833.id85984.diff
Wed, Apr 1, 5:02 AM
View All Files
Subscribers
gbe
imp
Contributor Reviews (src)

Details

Reviewers
delphij
markj
lwhsu
kib
gbe
Group Reviewers
manpages
Summary

fspacectl(2)'s cmd parameter supports SPACECTL_ALLOC besides
SPACECTL_DEALLOC in this commit. posix_fallocate(2) is implemented with
fo_fspacectl under the hood.

VOP_ALLOCATE(9) is expanded to have an extra flags and cred parameters.

uipc_shm and NFS client/server are converted to use the new
VOP_ALLOCATE(9) prototype.

struct fileops::fo_fallocate is eliminated.

Submitted by: Ka Ho Ng <khng@freebsdfoundation.org>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37237
Build 34126: arc lint + arc unit

Event Timeline

khng created this revision.Feb 21 2021, 8:33 AM
Herald added a reviewer: manpages. · View Herald TranscriptFeb 21 2021, 8:33 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
khng requested review of this revision.Feb 21 2021, 8:33 AM
Harbormaster completed remote builds in B37235: Diff 84381.Feb 21 2021, 8:33 AM
khng updated this revision to Diff 84383.Feb 21 2021, 8:38 AM

Update commit message

Harbormaster completed remote builds in B37237: Diff 84383.Feb 21 2021, 8:38 AM
khng added a parent revision: D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Feb 21 2021, 8:39 AM
khng updated this revision to Diff 84403.Feb 21 2021, 2:34 PM

Rebased

Harbormaster completed remote builds in B37246: Diff 84403.Feb 21 2021, 2:34 PM
khng updated this revision to Diff 84404.Feb 21 2021, 2:43 PM

Rebased on top of the newest D27194.

Harbormaster completed remote builds in B37247: Diff 84404.Feb 21 2021, 2:43 PM
khng added reviewers: delphij, markj, lwhsu, kib.Feb 21 2021, 2:45 PM
khng edited the summary of this revision. (Show Details)Feb 21 2021, 2:49 PM
khng updated this revision to Diff 84411.Feb 21 2021, 5:51 PM

nfsvno_allocate: Use cred from argument instead of td_ucred.

Harbormaster completed remote builds in B37254: Diff 84411.Feb 21 2021, 5:51 PM
khng updated this revision to Diff 84732.Feb 26 2021, 8:13 AM

Rebased.

Harbormaster completed remote builds in B37397: Diff 84732.Feb 26 2021, 8:13 AM
gbe added a subscriber: gbe.Mar 3 2021, 7:44 PM

Two small nits from manpages.

lib/libc/sys/fspacectl.2
67

...argument within the file system space.

70

...for a non-hole region.

khng updated this revision to Diff 85107.Mar 4 2021, 8:46 AM

Some fixes suggested by gbe@, with one more sentence explaining SPACECTL_ALLOC.

khng marked 2 inline comments as done.Mar 4 2021, 8:46 AM
Harbormaster completed remote builds in B37563: Diff 85107.Mar 4 2021, 8:47 AM
khng updated this revision to Diff 85108.Mar 4 2021, 8:48 AM

STYLE: normalizing date format to: February 8, 2021

Harbormaster completed remote builds in B37564: Diff 85108.Mar 4 2021, 8:48 AM
gbe accepted this revision.Mar 4 2021, 5:41 PM

LGTM from manpages

This revision is now accepted and ready to land.Mar 4 2021, 5:41 PM
khng updated this revision to Diff 85984.Mar 18 2021, 7:50 PM

Rebased and fixed manpage.

This revision now requires review to proceed.Mar 18 2021, 7:50 PM
Harbormaster completed remote builds in B37925: Diff 85984.Mar 18 2021, 7:50 PM
khng updated this revision to Diff 85988.Mar 18 2021, 7:56 PM

sys/fcntl.h fixes

Harbormaster completed remote builds in B37929: Diff 85988.Mar 18 2021, 7:56 PM
khng mentioned this in D28347: Add fspacectl(2), vn_deallocate(9) and VOP_DEALLOCATE(9)..Mar 22 2021, 6:14 PM
khng updated this revision to Diff 86185.Mar 23 2021, 10:13 AM

Moved the following into this revision:

	/* Translate to posix_fallocate(2) return value as needed. */
	if (error == ENOMEM)
		error = ENOSPC;
Harbormaster completed remote builds in B38008: Diff 86185.Mar 23 2021, 10:13 AM
khng updated this revision to Diff 87466.Apr 15 2021, 9:32 AM

manpage fixes.

Harbormaster completed remote builds in B38586: Diff 87466.Apr 15 2021, 9:32 AM
khng updated this revision to Diff 87536.Apr 16 2021, 5:36 AM

Compilation fixes after rebase

Harbormaster completed remote builds in B38616: Diff 87536.Apr 16 2021, 5:36 AM

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
8 lines
share/
man/
man9/
4 lines
sys/
fs/
nfsclient/
8 lines
nfsserver/
3 lines
kern/
7 lines
76 lines
26 lines
25 lines
2 lines
sys/
1 line
12 lines
tests/
sys/
file/
162 lines

Diff 84383

View Options

lib/libc/sys/fspacectl.2

Loading...
View Options

share/man/man9/VOP_ALLOCATE.9

Loading...
View Options

sys/fs/nfsclient/nfs_clvnops.c

Loading...
View Options

sys/fs/nfsserver/nfs_nfsdport.c

Loading...
View Options

sys/kern/sys_generic.c

Loading...
View Options

sys/kern/uipc_shm.c

Loading...
View Options

sys/kern/vfs_default.c

Loading...
View Options

sys/kern/vfs_vnops.c

Loading...
View Options

sys/kern/vnode_if.src

Loading...
View Options

sys/sys/fcntl.h

Loading...
View Options

sys/sys/file.h

Loading...
View Options

tests/sys/file/fspacectl_test.c

Loading...