Paths

Table of Contentst

Differential D24832

libcasper: Create a minimal cap_netdb service
ClosedPublic
Actions

Authored by freqlabs on May 13 2020, 10:46 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Aug 2, 8:14 PM

	Unknown Object (File)
	Sun, Aug 2, 3:49 AM

	Unknown Object (File)
	Sun, Aug 2, 3:39 AM

	Unknown Object (File)
	Sun, Aug 2, 3:36 AM

	Unknown Object (File)
	Sun, Aug 2, 3:20 AM

	Unknown Object (File)
	Sun, Aug 2, 2:11 AM

	Unknown Object (File)
	Sat, Aug 1, 8:07 AM

	Unknown Object (File)
	Fri, Jul 31, 3:30 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG94dc57159532: libcasper: Create a minimal cap_netdb service

Summary

Create a casper service for netdb functions.
Initially only cap_getprotobyname is implemented.

I'm working on capsicumizing sockstat and needed this one.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

freqlabs created this revision.May 13 2020, 10:46 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 13 2020, 10:46 PM

Herald added subscribers: jonathan, emaste, imp, bdrewery. · View Herald Transcript

freqlabs requested review of this revision.May 13 2020, 10:46 PM

OK from manpages.

kevans added a subscriber: kevans.May 14 2020, 2:33 PM

kevans added inline comments.

lib/libcasper/services/cap_netdb/Makefile
10	`SHLIB_MAJOR` should probably start at 1 for a new lib.
lib/libcasper/services/cap_netdb/tests/Makefile
15	This test compiles fine with the default `WARNS`... as a matter of fact, all the casper service tests seem to compile with the default `WARNS`, which makes me wonder if it was for crufty GCC. This can be dropped at any rate. =-)
lib/libcasper/services/cap_netdb/tests/netdb_test.c
68	Consider spelling this as `ATF_TC_WITHOUT_HEAD` instead and dropping the empty `ATF_TC_HEAD` below.

Incorporate feedback

freqlabs marked 3 inline comments as done.May 14 2020, 2:40 PM

I wonder if this should be incorporated as part of cap_net (D24688) instead?

freqlabs mentioned this in D24688: Introduce cap_net a network service for Casper..May 28 2020, 9:21 PM

freqlabs abandoned this revision.Oct 25 2020, 10:39 PM

I would prefer to commit this version. Sorry for me not responding for a while.

freqlabs updated this revision to Diff 79576.Nov 16 2020, 1:12 AM

freqlabs added a child revision: D26958: sockstat: Use libcasper to capsicumize.Nov 16 2020, 1:16 AM

oshogbo added inline comments.Nov 18 2020, 9:15 PM

lib/libcasper/services/cap_netdb/cap_netdb.c
50	if pp == NULL return ?
61	Maybe we can consume nvlist_t here? Instead of strdup just use take?
66	Why we start by free?
136	What if name won't be send?

Small nit for the copyright section of the man page.

lib/libcasper/services/cap_netdb/cap_netdb.3
2	The "All rights reserved." should be dropped.

Address feedback

freqlabs marked 5 inline comments as done.Jan 21 2021, 12:17 AM

@oshogbo okay to commit?

LGTM.
Do you have commit bit or should I commit this?

This revision is now accepted and ready to land.Apr 6 2021, 8:21 AM

freqlabs mentioned this in D26958: sockstat: Use libcasper to capsicumize.May 24 2021, 12:16 AM

Closed by commit rG94dc57159532: libcasper: Create a minimal cap_netdb service (authored by freqlabs). · Explain WhyJun 5 2021, 12:37 PM

This revision was automatically updated to reflect the committed changes.

freqlabs added a commit: rG94dc57159532: libcasper: Create a minimal cap_netdb service.

Revision Contents
Changeset List

Path

Size

lib/

libcasper/

services/

1 line

cap_netdb/

32 lines

49 lines

91 lines

165 lines

tests/

14 lines

94 lines

share/

mk/

src.libnames.mk

1 line

Diff 79576

lib/libcasper/services/Makefile

Loading...

lib/libcasper/services/cap_netdb/Makefile

Loading...

lib/libcasper/services/cap_netdb/cap_netdb.h

Loading...

lib/libcasper/services/cap_netdb/cap_netdb.3

Loading...

lib/libcasper/services/cap_netdb/cap_netdb.c

Loading...

lib/libcasper/services/cap_netdb/tests/Makefile

Loading...

lib/libcasper/services/cap_netdb/tests/netdb_test.c

Loading...

share/mk/src.libnames.mk

Loading...