To be compatible with Linux.
PR: 238404
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 31461
Event Timeline
Comment Actions
Thanks, I started doing this too but you are faster.
| lib/libthr/pthread.map | ||
|---|---|---|
| 250 | _pthread_get_name_np is not in the private namespace. Should it be there? Should we also provide non-weak _pthread_(get|set)name_np symbols? | |
| share/man/man3/pthread_set_name_np.3 | ||
| 82 | The new functions should be mentioned here too. It might be useful to note that getname/setname are "more" compatible with other OS'. | |
| share/man/man3/Makefile | ||
|---|---|---|
| 497 | Missing backslash. | |
| lib/libthr/pthread.map | ||
|---|---|---|
| 250 | I do not think we should export anything from the private namespace until there are users of it in the base system. Also we prefer to export non-ANSI-C symbols as weak (but this is not a hard rule). Our weak symbols have a semantic beyond what is required by ELF standard, rtld prefers non-weak over weak regardless of the lookup order. | |
Comment Actions
Make functions more compatible with Linux:
return errors
put declarations into pthread.h undef BSD_VISIBLE.
| lib/libthr/thread/thr_info.c | ||
|---|---|---|
| 48–49 | Duplicate. Typo? | |
| lib/libthr/thread/thr_info.c | ||
|---|---|---|
| 78 | I know it, I do not consider the case important, syscall would fail anyway for too long string, and this is the only case that really matters. But I fixed it anyway. | |
Comment Actions
Some Haskell ports are now failing with
ld-elf.so.1: /usr/local/bin/cabal: Undefined symbol "pthread_setname_np@FBSD_1.6"
Full log here: http://beefy18.nyi.freebsd.org/data/head-amd64-default/p538068_s361855/logs/hs-threadscope-0.2.12.log
Don't tell me this is another breaking change that would require us to have another flavor of bootstrap compiler.
Comment Actions
I do not know what exactly happens there, but the message itself means that the binary was built against newer libthr that exports the symbol, but then you tried to activate the binary with libthr that is older and does not export the symbol. We do support backward compatibility, where you can run binary against newer library than it was built against, but not older (that would be forward compatibility, unfortunately we still cannot see the future).