Paths

Table of Contentst

Differential D24103

Add the kyua test framework to the base system.
ClosedPublic
Actions

Authored by brooks on Mar 17 2020, 8:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 2:56 AM

	Unknown Object (File)
	Fri, Apr 12, 6:57 PM

	Unknown Object (File)
	Fri, Mar 29, 9:08 AM

	Unknown Object (File)
	Feb 23 2024, 6:02 PM

	Unknown Object (File)
	Jan 11 2024, 1:26 AM

	Unknown Object (File)
	Dec 22 2023, 11:22 PM

	Unknown Object (File)
	Dec 20 2023, 2:15 AM

	Unknown Object (File)
	Dec 12 2023, 6:19 PM

View All 45 Files

Subscribers

Details

Reviewers

kevans
emaste

Commits

rS359260: Import the kyua test framework.

Summary

Having kyua in the base system will simplify automated testing in CI and
eliminates bootstrapping issues on new platforms.

Note: This change includes adding liblutok which will be done seperately.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29987
Build 27800: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 17 2020, 8:35 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptMar 17 2020, 8:35 PM

Harbormaster completed remote builds in B29984: Diff 69607.Mar 17 2020, 8:35 PM

CI build in progress https://cirrus-ci.com/task/6332905735585792

The patch assumes lutok and kyua are extracted in contrib. If you want to test you can clone the repos there.

New CI job with tweak so the sources are available https://cirrus-ci.com/task/5382784613089280?command=package#L1883

Build works, but the install part fails with a seemingly unrelated issue...

Fix a typo in the mtree file for kyua.

Harbormaster completed remote builds in B29987: Diff 69613.Mar 17 2020, 11:31 PM

lwhsu added a subscriber: lwhsu.Mar 18 2020, 3:38 PM

mhorne added a subscriber: mhorne.Mar 18 2020, 4:17 PM

Ah, the CI error was my fault and caused by the mtree error. Working build here https://cirrus-ci.com/task/4696992890748928

Thanks to @arichardson for finding this on CheriBSD (it's really weird that my mtree didn't fail and the files ended up in the right place).

emaste accepted this revision.Mar 18 2020, 4:51 PM

emaste added inline comments.

lib/kyua/Makefile.inc
16	Maybe we should address this holistically later on
lib/kyua/Makefile.kyua
4	Not great but OK... something for us to address later on in our fork I guess

This revision is now accepted and ready to land.Mar 18 2020, 4:51 PM

The package also creates a tests user. Not sure if that is still required.

brooks added inline comments.Mar 18 2020, 6:00 PM

lib/kyua/Makefile.inc
16	I figure this is something we should fix in our fork on GitHub.
lib/kyua/Makefile.kyua
4	In this case I decided not to install the docs because they are fundamentally uninteresting and wanted to avoid patching. I also consider something like "/install/the/devel/kyua/pkg/for/docs".

emaste added inline comments.Mar 18 2020, 7:13 PM

lib/kyua/Makefile.kyua
4	Right, I'm not suggesting that we install the docs, just that later on (in the fork) we might want to more cleanly handle uninstalled docs - e.g. "Documentation omitted at build time" or whatever.

In D24103#530200, @arichardson wrote:

The package also creates a tests user. Not sure if that is still required.

Yeah, that's required by the default config. I'll add that (and probably commit it separately since that's immediatly MFC-able.)

Add the tests user, and unprivileged user from the default kyua config.

This revision now requires review to proceed.Mar 18 2020, 8:41 PM

Harbormaster completed remote builds in B30001: Diff 69662.Mar 18 2020, 8:41 PM

emaste accepted this revision.Mar 18 2020, 8:48 PM

This revision is now accepted and ready to land.Mar 18 2020, 8:48 PM

brooks mentioned this in rS359247: Add the tests user, an unprivileged user from the default kyua config..Mar 23 2020, 5:12 PM

trasz added a subscriber: trasz.Mar 23 2020, 5:52 PM

brooks mentioned this in rS359255: Add liblutok a lightweight C++ API for lua..Mar 23 2020, 6:26 PM

brooks mentioned this in rS359262: Improve LIBADD/_DP_* for kyua libraries..Mar 23 2020, 9:21 PM

Committed in rS359260.

brooks mentioned this in rS359339: MFC r359247:.Mar 26 2020, 5:56 PM

brooks mentioned this in rS359341: MFC r359247:.Mar 26 2020, 6:00 PM

brooks added a commit: rS359260: Import the kyua test framework..Jul 15 2020, 2:41 PM

Revision Contents
Changeset List

Path

Size

etc/

mtree/

2 lines

8 lines

lib/

2 lines

kyua/

10 lines

18 lines

9 lines

cli/

28 lines

122 lines

drivers/

11 lines

engine/

21 lines

model/

12 lines

store/

17 lines

utils/

64 lines

70 lines

liblutok/

26 lines

share/

mk/

src.libnames.mk

31 lines

tools/

build/

mk/

OptionalObsoleteFiles.inc

25 lines

usr.bin/

1 line

kyua/

64 lines

Diff 69613

etc/mtree/BSD.root.dist

Loading...

etc/mtree/BSD.usr.dist

Loading...

lib/Makefile

Loading...

lib/kyua/Makefile

Loading...

lib/kyua/Makefile.inc

Loading...

lib/kyua/Makefile.kyua

Loading...

lib/kyua/cli/Makefile

Loading...

lib/kyua/config.h

Loading...

lib/kyua/drivers/Makefile

Loading...

lib/kyua/engine/Makefile

Loading...

lib/kyua/model/Makefile

Loading...

lib/kyua/store/Makefile

Loading...

lib/kyua/utils/Makefile

Loading...

lib/kyua/utils/defs.hpp

Loading...

lib/liblutok/Makefile

Loading...

share/mk/src.libnames.mk

Loading...

tools/build/mk/OptionalObsoleteFiles.inc

Loading...

usr.bin/Makefile

Loading...

usr.bin/kyua/Makefile

Loading...