Paths

Table of Contentst

Differential D21250

Move phys_avail and dump_avail into MI code.
ClosedPublic
Actions

Authored by jeff on Aug 13 2019, 5:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 11:47 AM

	Unknown Object (File)
	Sun, Nov 24, 11:45 AM

	Unknown Object (File)
	Thu, Nov 21, 6:46 AM

	Unknown Object (File)
	Sun, Nov 17, 5:30 AM

	Unknown Object (File)
	Oct 9 2024, 5:23 AM

	Unknown Object (File)
	Oct 2 2024, 12:28 PM

	Unknown Object (File)
	Oct 1 2024, 11:02 PM

	Unknown Object (File)
	Oct 1 2024, 10:16 PM

View All 44 Files

Subscribers

Details

Reviewers

manu
kib
jhb
jhibbits
br
mhorne
marius
markj

Commits

rS351108: Move phys_avail definition into MI code. It is consumed in the MI layer and

Summary

I need to move phys_avail and dump_avail into MI code so that I can write boot time allocators. This also eliminates a lot of confusing redundant code and definitions. Since MI is manipulating these arrays it makes sense to define them MI.

The following two revisions depend on this refactoring:

https://reviews.freebsd.org/D21251
https://reviews.freebsd.org/D21252

Test Plan

I have built universe and tested on amd64.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25846
Build 24417: arc lint + arc unit

Event Timeline

jeff created this revision.Aug 13 2019, 5:31 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 13 2019, 5:31 PM

Herald added subscribers: bdragon, jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B25846: Diff 60746.Aug 13 2019, 5:31 PM

jeff edited the summary of this revision. (Show Details)Aug 13 2019, 5:36 PM

jeff added reviewers: kib, jhb, jhibbits.

jeff mentioned this in D21251: Add phys_avail allocation routines..Aug 13 2019, 5:40 PM

jhb added inline comments.Aug 13 2019, 5:49 PM

sys/vm/vm_param.h
132	Maybe `(PHYS_AVAIL_ENTRIES + 2)` (similar to how the default for PHYS_AVAIL_ENTRIES is defined above)
sys/vm/vm_phys.c
122	Do you want to add a note here to say something like: "Initially dump_avail matches phys_avail, but phys_avail is modified during boot to provide early memory allocations before the VM system is able to allocate memory."?

jeff edited the summary of this revision. (Show Details)Aug 13 2019, 5:53 PM

jeff edited the test plan for this revision. (Show Details)

jeff added reviewers: br, mhorne, marius, markj.

jeff added inline comments.Aug 13 2019, 5:56 PM

sys/amd64/include/pmap.h
229	This crept in from a different commit. I will fix before I merge.

markj accepted this revision.Aug 13 2019, 7:32 PM

markj added inline comments.

sys/mips/mips/machdep.c
144	I think this can actually be PHYS_AVAIL_ENTRIES, but it doesn't really matter.
sys/vm/vm_phys.h
52	Extra newline.

This revision is now accepted and ready to land.Aug 13 2019, 7:32 PM

(assuming Mark and John notes are handled)

jeff closed this revision.Aug 16 2019, 4:56 PM

jeff added a commit: rS351108: Move phys_avail definition into MI code. It is consumed in the MI layer and.Sep 13 2019, 9:21 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

23 lines

include/

4 lines

arm/

arm/

busdma_machdep-v4.c

2 lines

busdma_machdep-v6.c

2 lines

3 lines

minidump_machdep.c

4 lines

33 lines

include/

3 lines

arm64/

include/

3 lines

i386/

i386/

23 lines

minidump_machdep_base.c

3 lines

include/

2 lines

kern/

2 lines

mips/

atheros/

ar531x/

ar5315_machdep.c

3 lines

ar71xx_machdep.c

3 lines

beri/

2 lines

broadcom/

3 lines

cavium/

octeon_machdep.c

3 lines

include/

8 lines

ingenic/

jz4780_machdep.c

3 lines

malta/

malta_machdep.c

2 lines

mediatek/

3 lines

mips/

busdma_machdep.c

1 line

5 lines

1 line

nlm/

2 lines

powerpc/

aim/

4 lines

3 lines

include/

7 lines

10 lines

powerpc/

1 line

pmap_dispatch.c

1 line

riscv/

include/

3 lines

riscv/

9 lines

sparc64/

include/

1 line

sparc64/

9 lines

vm/

5 lines

4 lines

14 lines

x86/

x86/

4 lines

Diff 60746

sys/amd64/amd64/machdep.c

Loading...

sys/amd64/include/pmap.h

Loading...

sys/arm/arm/busdma_machdep-v4.c

Loading...

sys/arm/arm/busdma_machdep-v6.c

Loading...

sys/arm/arm/mem.c

Loading...

sys/arm/arm/minidump_machdep.c

Loading...

sys/arm/arm/physmem.c

Loading...

sys/arm/include/pmap.h

Loading...

sys/arm64/include/pmap.h

Loading...

sys/i386/i386/machdep.c

Loading...

sys/i386/i386/minidump_machdep_base.c

Loading...

sys/i386/include/pmap.h

Loading...

sys/kern/kern_dump.c

Loading...

sys/mips/atheros/ar531x/ar5315_machdep.c

Loading...

sys/mips/atheros/ar71xx_machdep.c

Loading...

sys/mips/beri/beri_machdep.c

Loading...

sys/mips/broadcom/bcm_machdep.c

Loading...

sys/mips/cavium/octeon_machdep.c

Loading...

sys/mips/include/pmap.h

Loading...

sys/mips/ingenic/jz4780_machdep.c

Loading...

sys/mips/malta/malta_machdep.c

Loading...

sys/mips/mediatek/mtk_machdep.c

Loading...

sys/mips/mips/busdma_machdep.c

Loading...

sys/mips/mips/machdep.c

Loading...

sys/mips/mips/pmap.c

Loading...

sys/mips/nlm/xlp_machdep.c

Loading...

sys/powerpc/aim/mmu_oea.c

Loading...

sys/powerpc/aim/mmu_oea64.c

Loading...

sys/powerpc/include/pmap.h

Loading...

sys/powerpc/include/vmparam.h

Loading...

sys/powerpc/powerpc/machdep.c

Loading...

sys/powerpc/powerpc/pmap_dispatch.c

Loading...

sys/riscv/include/pmap.h

Loading...

sys/riscv/riscv/machdep.c

Loading...

sys/sparc64/include/pmap.h

Loading...

sys/sparc64/sparc64/pmap.c

Loading...

sys/vm/vm_param.h

Loading...

sys/vm/vm_phys.h

Loading...

sys/vm/vm_phys.c

Loading...

sys/x86/x86/nexus.c

Loading...