Improve debugging options in bcm2835_sdhci.c
ClosedPublic
Actions

Authored by bz on Mar 29 2019, 9:42 AM.

Details

Reviewers

kibab
marius
gonzo
manu
andrew

Commits

rS345757: Improve debugging options in bcm2835_sdhci.c

Summary

Improve debugging options in bcm2835_sdhci.c

Similar to bcm2835_sdhost.c add a TUNABLE and SYSCTL to selectively
turn on debugging printfs if debugging is turned on at compile time.

Sponsored by: The FreeBSD Foundation
MFC After: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Mar 29 2019, 9:42 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptMar 29 2019, 9:42 AM

Harbormaster completed remote builds in B23374: Diff 55585.Mar 29 2019, 9:42 AM

bz added a reviewer: manu.Mar 29 2019, 9:42 AM

bz added a subscriber: emaste.Mar 29 2019, 9:47 AM

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

This revision is now accepted and ready to land.Mar 29 2019, 11:39 AM

In D19745#423290, @andrew wrote:

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

They are extremely common in most device drivers (unrelated to the architecture, more often spelt in upper cases).

gonzo accepted this revision.Mar 29 2019, 5:27 PM

Closed by commit rS345757: Improve debugging options in bcm2835_sdhci.c (authored by bz). · Explain WhyMar 31 2019, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

broadcom/

bcm2835/

bcm2835_sdhci.c

13 lines

Diff 55654

View Options

head/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c

Show First 20 Lines • Show All 127 Lines • ▼ Show 20 Lines	SUBDIR= ${_addr2line} \
pathchk \		pathchk \
perror \		perror \
pr \		pr \
printenv \		printenv \
printf \		printf \
procstat \		procstat \
protect \		protect \
rctl \		rctl \
		${_readelf} \
renice \		renice \
rev \		rev \
revoke \		revoke \
rpcinfo \		rpcinfo \
rs \		rs \
rup \		rup \
rusers \		rusers \
rwall \		rwall \
▲ Show 20 Lines • Show All 89 Lines • ▼ Show 20 Lines
.if ${MK_EE} != "no"		.if ${MK_EE} != "no"
SUBDIR+= ee		SUBDIR+= ee
.endif		.endif

.if ${MK_ELFTOOLCHAIN_TOOLS} != "no"		.if ${MK_ELFTOOLCHAIN_TOOLS} != "no"
_addr2line= addr2line		_addr2line= addr2line
_elfcopy= elfcopy		_elfcopy= elfcopy
_nm= nm		_nm= nm
		_readelf= readelf
_size= size		_size= size
_strings= strings		_strings= strings
.endif		.endif

.if ${MK_FILE} != "no"		.if ${MK_FILE} != "no"
SUBDIR+= file		SUBDIR+= file
.endif		.endif

▲ Show 20 Lines • Show All 175 Lines • Show Last 20 Lines

Improve debugging options in bcm2835_sdhci.cClosedPublicActions