Page MenuHomeFreeBSD

Improve debugging options in bcm2835_sdhci.c
ClosedPublic

Authored by bz on Mar 29 2019, 9:42 AM.

Details

Summary

Improve debugging options in bcm2835_sdhci.c

Similar to bcm2835_sdhost.c add a TUNABLE and SYSCTL to selectively
turn on debugging printfs if debugging is turned on at compile time.

Sponsored by: The FreeBSD Foundation
MFC After: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz created this revision.Mar 29 2019, 9:42 AM
bz added a reviewer: manu.Mar 29 2019, 9:42 AM
bz added a subscriber: emaste.Mar 29 2019, 9:47 AM
andrew accepted this revision.Mar 29 2019, 11:39 AM

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

This revision is now accepted and ready to land.Mar 29 2019, 11:39 AM
bz added a comment.Mar 29 2019, 11:51 AM

I wonder if there is a way to make this generic as the dprintf or similar macro seems to be common in arm code.

They are extremely common in most device drivers (unrelated to the architecture, more often spelt in upper cases).

gonzo accepted this revision.Mar 29 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.