sysctl has not -R option
ClosedPublic
Actions

Authored by asiciliano on Jan 29 2019, 1:18 AM.

Details

Reviewers

cem
bcr
brooks
dab
0mp
imp
ygy

Group Reviewers

manpages

Commits

rS344114: MFC r343930:
rS343930: Remove -R option which was added to sysctl(8) man page per r244106, but it is…

Summary

This commit 244106 implemented -T and -W options but -R was added to the manual page (.Sh SYNOPSIS).

Test Plan

% sysctl -Ra
sysctl: illegal option -- R
usage: sysctl [-bdehiNnoqTtWx] [ -B <bufsize> ] [-f filename] name[=value] ...
       sysctl [-bdehNnoqTtWx] [ -B <bufsize> ] -a

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asiciliano created this revision.Jan 29 2019, 1:18 AM

Herald added a reviewer: manpages. · View Herald TranscriptJan 29 2019, 1:18 AM

Herald added a subscriber: imp. · View Herald Transcript

asiciliano edited the summary of this revision. (Show Details)Jan 29 2019, 1:27 AM

Nice find!

This revision is now accepted and ready to land.Jan 29 2019, 10:18 AM

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

In D19012#406455, @crees wrote:

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

It depends. ls(1) has -ABab while grep(1) has -AaBb. Personally, I prefer -AaBb. It's also what the example for the Fl macro suggests in mdoc(7):

.Op Fl 1AaCcdFfgHhikLlmnopqRrSsTtux

In D19012#406701, @0mp wrote:
In D19012#406455, @crees wrote:

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

It depends. ls(1) has -ABab while grep(1) has -AaBb. Personally, I prefer -AaBb. It's also what the example for the Fl macro suggests in mdoc(7):
.Op Fl 1AaCcdFfgHhikLlmnopqRrSsTtux

The official style is AaBbCc not ABCabc. This is true for both the usage() message in the program and the usage in the man page. longopts are a total crap shoot, we have no standard for those, but single letter ops are well known: alphabetical order, with the upper case of the letter immediately before the lower case.

imp accepted this revision.Jan 30 2019, 4:21 PM

Thank you all for the comments,
Could you commit the diff? Thanks.

I will go ahead and commit it.

Closed by commit rS343930: Remove -R option which was added to sysctl(8) man page per r244106, but it is… (authored by ygy). · Explain WhyFeb 9 2019, 4:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

sysctl/

sysctl.8

6 lines

Diff 53722

View Options

sysctl has not -R optionClosedPublicActions