Page MenuHomeFreeBSD

sysctl has not -R option
ClosedPublic

Authored by asiciliano on Jan 29 2019, 1:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 6:41 PM
Unknown Object (File)
Tue, Nov 26, 6:41 PM
Unknown Object (File)
Tue, Nov 26, 6:40 PM
Unknown Object (File)
Tue, Nov 26, 6:16 PM
Unknown Object (File)
Oct 14 2024, 3:33 PM
Unknown Object (File)
Oct 14 2024, 10:07 AM
Unknown Object (File)
Oct 14 2024, 10:07 AM
Unknown Object (File)
Oct 14 2024, 10:07 AM

Details

Summary

This commit 244106 implemented -T and -W options but -R was added to the manual page (.Sh SYNOPSIS).

Test Plan
% sysctl -Ra
sysctl: illegal option -- R
usage: sysctl [-bdehiNnoqTtWx] [ -B <bufsize> ] [-f filename] name[=value] ...
       sysctl [-bdehNnoqTtWx] [ -B <bufsize> ] -a

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp added a subscriber: 0mp.

Nice find!

This revision is now accepted and ready to land.Jan 29 2019, 10:18 AM

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

It depends. ls(1) has -ABab while grep(1) has -AaBb. Personally, I prefer -AaBb. It's also what the example for the Fl macro suggests in mdoc(7):

.Op Fl 1AaCcdFfgHhikLlmnopqRrSsTtux
In D19012#406701, @0mp wrote:

I think it should be NRTbdehnotqx, shouldn't it? I'm sure most of our manpages are like that.

It depends. ls(1) has -ABab while grep(1) has -AaBb. Personally, I prefer -AaBb. It's also what the example for the Fl macro suggests in mdoc(7):

.Op Fl 1AaCcdFfgHhikLlmnopqRrSsTtux

The official style is AaBbCc not ABCabc. This is true for both the usage() message in the program and the usage in the man page. longopts are a total crap shoot, we have no standard for those, but single letter ops are well known: alphabetical order, with the upper case of the letter immediately before the lower case.

Thank you all for the comments,
Could you commit the diff? Thanks.

ygy added a subscriber: ygy.

I will go ahead and commit it.

This revision was automatically updated to reflect the committed changes.