Page MenuHomeFreeBSD
Differential D13295

arm: add generic syscon driver
ClosedPublic
Actions

Authored by kevans on Nov 29 2017, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 8:25 PM
Unknown Object (File)
Wed, Jan 1, 3:53 PM
Unknown Object (File)
Dec 5 2024, 12:54 PM
Unknown Object (File)
Nov 13 2024, 1:28 AM
Unknown Object (File)
Nov 6 2024, 8:01 PM
Unknown Object (File)
Oct 27 2024, 5:07 PM
Unknown Object (File)
Oct 11 2024, 9:41 AM
Unknown Object (File)
Sep 24 2024, 2:58 PM
View All 61 Files
Subscribers
andrew
bcr
imp

Details

Reviewers
manu
emaste
mmel
Group Reviewers
arm64
ARM
Commits
rS326773: Add generic 'syscon' driver
Summary

Upstream dts for allwinner will require a syscon driver, since the emac node coming in 4.15 will be using xref to /soc/syscon for configuring the emac clock. Add a generic syscon driver to attach to /soc/syscon for use by if_awg.

This syscon driver was written by mmel@; I only applied minor style/comment changes and made probe return BUS_PROBE_GENERIC.

Tested on: BananaPi-M3 (a83t)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 13209

Event Timeline

kevans created this revision.Nov 29 2017, 5:45 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptNov 29 2017, 5:45 PM
kevans added a child revision: D13296: if_awg: Use syscon driver if it's specified instead of passing in syscon register.Nov 29 2017, 5:47 PM
bcr added a subscriber: bcr.Nov 30 2017, 9:47 AM

Typo

sys/arm/arm/syscon_if.m
35 ↗(On Diff #35965)

s/Accesor/Accessor/

manu added a comment.Nov 30 2017, 10:08 AM

This will be used in arm64 and maybe mips ?
Should we put it in sys/dev/ directly instead ?

andrew added inline comments.Nov 30 2017, 10:55 AM
sys/arm/allwinner/files.allwinner
3–4

This should be in sys/conf/files.arm and be optional syscon

kevans added a comment.Nov 30 2017, 2:28 PM
In D13295#277602, @manu wrote:

This will be used in arm64 and maybe mips ?
Should we put it in sys/dev/ directly instead ?

That sounds reasonable, but the naming is kind of unfortunate since we have the completely unrelated dev/syscons that's a single character away.

@andrew Do we have documentation on the syntax for files files so that I can make sure I'm doing what I intend to be doing- both here and in dependencies of this thing?

kevans updated this revision to Diff 36022.Nov 30 2017, 9:46 PM

Something like this, perhaps? I'll also need to update D13296 to note dependency on 'syscon' for if_awg.c and add syscon to arm/GENERIC.

sys/arm/arm/syscon_if.m
35 ↗(On Diff #35965)

Whoops, thanks!

kevans updated this revision to Diff 36023.Nov 30 2017, 9:51 PM

Saw the other half of @andrew's comment; moved files bits to sys/conf/files.arm

manu added inline comments.Dec 1 2017, 8:06 PM
sys/conf/files.arm
141 ↗(On Diff #36023)

Since we're gonna use it on armv7 and arm64 this should be in sys/conf/files with 'optional fdt syscon

manu added reviewers: arm64, ARM.Dec 1 2017, 8:06 PM
kevans updated this revision to Diff 36128.Dec 2 2017, 11:55 PM

Bounce inclusion over to sys/conf/files

manu accepted this revision as: manu.Dec 5 2017, 2:18 PM
This revision is now accepted and ready to land.Dec 5 2017, 2:18 PM
Closed by commit rS326773: Add generic 'syscon' driver (authored by kevans). · Explain WhyDec 11 2017, 6:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
3 lines
dev/
syscon/
185 lines
55 lines

Diff 36022

View Options

sys/arm/allwinner/files.allwinner

Loading...
View Options

sys/dev/syscon/syscon.c

Loading...
View Options

sys/dev/syscon/syscon_if.m

Loading...