Page MenuHomeFreeBSD
Differential D13296

if_awg: Use syscon driver if it's specified instead of passing in syscon register
ClosedPublic
Actions

Authored by kevans on Nov 29 2017, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 4:17 AM
Unknown Object (File)
Fri, Jan 17, 11:11 PM
Unknown Object (File)
Fri, Jan 17, 11:01 PM
Unknown Object (File)
Jan 7 2025, 10:01 PM
Unknown Object (File)
Dec 30 2024, 10:25 PM
Unknown Object (File)
Dec 4 2024, 9:25 PM
Unknown Object (File)
Dec 4 2024, 9:25 PM
Unknown Object (File)
Dec 4 2024, 9:25 PM
View All 96 Files
Subscribers
andrew
imp

Details

Reviewers
manu
emaste
Commits
rS327563: if_awg: Use syscon prop if it exists
Summary

Maintain backwards compatibility with the old method for boards that we get .dtb from u-boot, such as pine64, while accommodating the Linux 4.15 method of using syscon for emac.

Tested on: Banana Pi-M3 (a83t)
Tested on: Pine64 (a64)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Nov 29 2017, 5:47 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptNov 29 2017, 5:47 PM
kevans added a parent revision: D13295: arm: add generic syscon driver.Nov 29 2017, 5:47 PM
kevans updated this revision to Diff 35994.Nov 30 2017, 3:07 AM

Allow legacy method of specifying syscon as a register in emac node to remain for now so that we don't break older dts included in u-boot (even as of u-boot -HEAD, as far as I can tell).

This iteration hasn't been tested beyond building, but it's not a major change and I expect no regressions. Even if syscon node+xref exists and syscon register has been left accidentally in emac node, this should still succeed and use sc->syscon due to pass that syscon attaches at.

kevans retitled this revision from if_awg: Use syscon driver instead of passing in syscon register to if_awg: Use syscon driver if it's specified instead of passing in syscon register.Nov 30 2017, 3:10 AM
kevans mentioned this in D13295: arm: add generic syscon driver.Nov 30 2017, 9:46 PM
kevans updated this revision to Diff 36129.Dec 3 2017, 12:02 AM
kevans edited the summary of this revision. (Show Details)

Add dependency on syscon, make sure it's included in GENERIC as well.

kevans updated this revision to Diff 37422.Jan 2 2018, 7:16 PM

Update to reflect syscon adoption into extres framework

Herald added 1 blocking reviewer(s): manu. · View Herald TranscriptJan 2 2018, 7:16 PM
kevans edited the summary of this revision. (Show Details)Jan 2 2018, 7:16 PM
kevans updated this revision to Diff 37423.Jan 2 2018, 7:35 PM

Upload correct version with a little more error handling and less redundant initialization

manu accepted this revision.Jan 4 2018, 4:37 PM
This revision is now accepted and ready to land.Jan 4 2018, 4:37 PM
Closed by commit rS327563: if_awg: Use syscon prop if it exists (authored by kevans). · Explain WhyJan 4 2018, 10:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
2 lines
63 lines
conf/
1 line
arm64/
conf/
1 line
conf/
2 lines

Diff 37538

View Options

head/sys/arm/allwinner/files.allwinner

Loading...
View Options

head/sys/arm/allwinner/if_awg.c

Loading...
View Options

head/sys/arm/conf/GENERIC

Loading...
View Options

head/sys/arm64/conf/GENERIC

Loading...
View Options

head/sys/conf/files.arm64

Loading...