Page MenuHomeFreeBSD

arm: add generic syscon driver
ClosedPublic

Authored by kevans on Nov 29 2017, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 7:27 AM
Unknown Object (File)
Fri, May 3, 7:27 AM
Unknown Object (File)
Fri, May 3, 7:27 AM
Unknown Object (File)
Fri, May 3, 5:53 AM
Unknown Object (File)
Fri, May 3, 5:52 AM
Unknown Object (File)
Fri, May 3, 5:52 AM
Unknown Object (File)
Fri, May 3, 2:11 AM
Unknown Object (File)
Feb 20 2024, 11:47 PM
Subscribers

Details

Summary

Upstream dts for allwinner will require a syscon driver, since the emac node coming in 4.15 will be using xref to /soc/syscon for configuring the emac clock. Add a generic syscon driver to attach to /soc/syscon for use by if_awg.

This syscon driver was written by mmel@; I only applied minor style/comment changes and made probe return BUS_PROBE_GENERIC.

Tested on: BananaPi-M3 (a83t)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 13210

Event Timeline

Typo

sys/arm/arm/syscon_if.m
35 ↗(On Diff #35965)

s/Accesor/Accessor/

This will be used in arm64 and maybe mips ?
Should we put it in sys/dev/ directly instead ?

sys/arm/allwinner/files.allwinner
3–4 ↗(On Diff #35965)

This should be in sys/conf/files.arm and be optional syscon

In D13295#277602, @manu wrote:

This will be used in arm64 and maybe mips ?
Should we put it in sys/dev/ directly instead ?

That sounds reasonable, but the naming is kind of unfortunate since we have the completely unrelated dev/syscons that's a single character away.

@andrew Do we have documentation on the syntax for files files so that I can make sure I'm doing what I intend to be doing- both here and in dependencies of this thing?

Something like this, perhaps? I'll also need to update D13296 to note dependency on 'syscon' for if_awg.c and add syscon to arm/GENERIC.

sys/arm/arm/syscon_if.m
35 ↗(On Diff #35965)

Whoops, thanks!

Saw the other half of @andrew's comment; moved files bits to sys/conf/files.arm

sys/conf/files.arm
141

Since we're gonna use it on armv7 and arm64 this should be in sys/conf/files with 'optional fdt syscon

Bounce inclusion over to sys/conf/files

This revision is now accepted and ready to land.Dec 5 2017, 2:18 PM
This revision was automatically updated to reflect the committed changes.