Details

Reviewers

sbruno
scottl
smh
jeffrey.e.pieper_intel.com
erj
cramerj_intel.com
shurd

Group Reviewers

Intel Networking

Commits

rS320688: ixgbe(4): Update HEAD (p3) to 3.2.12-k

Summary

Update to ixgbe including:

Support for X550EM devices.
Support for Bypass adapters.
Flow Director code moved to separate files
SR-IOV code moved to separate files
Netmap code moved to separate files

This does NOT contain iflib support. Review D10293 (with iflib support) will be abandoned and a new review will be created to add iflib support.

Test Plan

Work-in-progress. Respectfully request waiting for Jeff's team to perform a validation pass before committing.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10159
Build 10582: arc lint + arc unit

Event Timeline

cramerj_intel.com created this revision.Jun 16 2017, 1:31 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 16 2017, 1:31 AM

Fixed compilation issue with unused variables.

Fixed compilation error with ixv when compiled dynamically.

Removed "Frame Limit" flag as it seems unnecessary.

Harbormaster completed remote builds in B10020: Diff 29876.Jun 20 2017, 9:39 PM

Fixed version error.

Harbormaster completed remote builds in B10039: Diff 29915.Jun 21 2017, 4:47 PM

Fixed a load error when trying to load ixv dynamically.

cramerj_intel.com mentioned this in D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.Jun 27 2017, 8:39 PM

Fixed unresolved symbol issue with ixv.

Ship it

This revision is now accepted and ready to land.Jun 29 2017, 11:50 PM

We need to hold off on committing this. We are investigating some issues that were discovered today.

This revision now requires changes to proceed.Jul 1 2017, 2:54 AM

erj accepted this revision.Jul 5 2017, 5:28 PM

cramerj_intel.com accepted this revision.Jul 7 2017, 8:36 PM

jeffrey.e.pieper_intel.com accepted this revision.Jul 7 2017, 11:15 PM

This revision is now accepted and ready to land.Jul 7 2017, 11:15 PM

cramerj_intel.com closed this revision.Jul 8 2017, 1:43 AM

Committed in r320688

In the future when you find yourselves implementing synchronization primitives like swfw_sync or your hand rolled locks in if_bypass.c please make sure you get the attention and sign off from @markj, @jhb, or myself.

sys/dev/ixgbe/if_bypass.c
48	This lock needs to be replaced.

kmacy added a reviewer: shurd.Aug 23 2017, 6:33 AM

Also, can we stop massively refactoring the drivers until after the iflib version goes in to HEAD? And in general, there's a lot of non-productive function shuffling that goes on in Intel drivers that makes it a lot more work for downstream users maintaining their own branches.

kmacy added inline comments.Aug 25 2017, 10:55 PM

sys/dev/ixgbe/ixgbe_fdir.h
45	Has this code ever been tested with IXGBE_FDIR enabled? This leads to duplicate symbols.

ixgbe(4): Update HEAD (p3) to 3.2.12-kClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30153

sys/conf/files

sys/dev/ixgbe/if_bypass.c

sys/dev/ixgbe/if_fdir.c

sys/dev/ixgbe/if_ix.c

sys/dev/ixgbe/if_ixv.c

sys/dev/ixgbe/if_sriov.c

sys/dev/ixgbe/ix_txrx.c

sys/dev/ixgbe/ixgbe.h

sys/dev/ixgbe/ixgbe_82598.h

sys/dev/ixgbe/ixgbe_82598.c

sys/dev/ixgbe/ixgbe_82599.h

sys/dev/ixgbe/ixgbe_82599.c

sys/dev/ixgbe/ixgbe_api.h

sys/dev/ixgbe/ixgbe_api.c

sys/dev/ixgbe/ixgbe_bypass.h

sys/dev/ixgbe/ixgbe_common.h

sys/dev/ixgbe/ixgbe_common.c

sys/dev/ixgbe/ixgbe_dcb.h

sys/dev/ixgbe/ixgbe_dcb.c

sys/dev/ixgbe/ixgbe_dcb_82598.h

sys/dev/ixgbe/ixgbe_dcb_82598.c

sys/dev/ixgbe/ixgbe_dcb_82599.h

sys/dev/ixgbe/ixgbe_dcb_82599.c

sys/dev/ixgbe/ixgbe_fdir.h

sys/dev/ixgbe/ixgbe_features.h

sys/dev/ixgbe/ixgbe_mbx.h

sys/dev/ixgbe/ixgbe_mbx.c

sys/dev/ixgbe/ixgbe_netmap.h

sys/dev/ixgbe/ixgbe_netmap.c

sys/dev/ixgbe/ixgbe_osdep.h

sys/dev/ixgbe/ixgbe_osdep.c

sys/dev/ixgbe/ixgbe_phy.h

sys/dev/ixgbe/ixgbe_phy.c

sys/dev/ixgbe/ixgbe_rss.h

sys/dev/ixgbe/ixgbe_sriov.h

sys/dev/ixgbe/ixgbe_type.h

sys/dev/ixgbe/ixgbe_vf.h

sys/dev/ixgbe/ixgbe_vf.c

sys/dev/ixgbe/ixgbe_x540.h

sys/dev/ixgbe/ixgbe_x540.c

sys/dev/ixgbe/ixgbe_x550.h

sys/dev/ixgbe/ixgbe_x550.c

sys/modules/ix/Makefile

sys/modules/ixv/Makefile

ixgbe(4): Update HEAD (p3) to 3.2.12-k
ClosedPublic
Actions

Revision Contents
Changeset List