Page MenuHomeFreeBSD
Differential D9680

Increase EFI MSDOSFS image size to 512Kib
ClosedPublic
Actions

Authored by allanjude on Feb 20 2017, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 4:26 PM
Unknown Object (File)
Dec 20 2023, 7:17 AM
Unknown Object (File)
Nov 13 2023, 12:12 PM
Unknown Object (File)
Nov 10 2023, 3:03 PM
Unknown Object (File)
Nov 8 2023, 5:27 PM
Unknown Object (File)
Nov 7 2023, 11:27 AM
Unknown Object (File)
Nov 7 2023, 7:26 AM
Unknown Object (File)
Nov 6 2023, 7:49 AM
View All 36 Files
Subscribers
andrew

Details

Reviewers
emaste
manu
imp
tsoome
eric_metricspace.net
Commits
rS323554: Increase EFI boot file size frok 128k to 384k
Summary

This patch increases the size of the msdosfs image generated for EFI boot1 to 512Kib. This is a part of https://reviews.freebsd.org/D7589, and is necessary to fit the GELI EFI support, which increases the size of the boot1 program.

This patch is a component of https://reviews.freebsd.org/D7589.

Test Plan

This does not affect behavior at all. It merely causes a larger image to be generated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

eric_metricspace.net updated this revision to Diff 25399.Feb 20 2017, 12:12 AM
eric_metricspace.net retitled this revision from to Increase EFI MSDOSFS image size to 512Kib.
eric_metricspace.net updated this object.
eric_metricspace.net edited the test plan for this revision. (Show Details)
eric_metricspace.net added reviewers: allanjude, imp, emaste, tsoome, manu.
eric_metricspace.net set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: andrew. · View Herald TranscriptFeb 20 2017, 12:12 AM
allanjude accepted this revision.Feb 20 2017, 12:16 AM
allanjude edited edge metadata.

This is more of a project-wide question, hopefully @emaste or something can answer it:

Does it still make sense to uuencode binary files like this? SVN can handle binary files just fine.

This revision is now accepted and ready to land.Feb 20 2017, 12:16 AM
emaste edited edge metadata.Feb 21 2017, 3:46 PM

Does it still make sense to uuencode binary files like this? SVN can handle binary files just fine.

I would prefer we stopped uuencoding binary files, and just committed them directly. As far as I'm concerned it's a carryover from the CVS days, and there is no concern with any of the VCSes relevant to us today (svn/git/p4/hg, or esoteric ones like ClearCase used by some downstream consumers).

emaste mentioned this in D10931: boot1 generate-fat: generate all templates at once.May 26 2017, 1:47 PM
eric_metricspace.net updated this revision to Diff 30194.Jun 29 2017, 12:36 AM
eric_metricspace.net edited edge metadata.

Rebase to HEAD

This revision now requires review to proceed.Jun 29 2017, 12:36 AM
allanjude commandeered this revision.Jul 1 2017, 6:02 PM
allanjude edited reviewers, added: eric_metricspace.net; removed: allanjude.

I am going to do the uuencode change as well.

allanjude updated this revision to Diff 30290.Jul 1 2017, 6:05 PM

Switch from uuencoded bzip to raw xz

Harbormaster completed remote builds in B10233: Diff 30290.Jul 1 2017, 6:05 PM
eric_metricspace.net accepted this revision.Jul 1 2017, 8:40 PM

As long as the max size is increased, it should work with my downstream changes.

This revision is now accepted and ready to land.Jul 1 2017, 8:40 PM
eric_metricspace.net added a child revision: D10447: Unify boot1 with loader.Jul 12 2017, 10:02 AM
imp edited edge metadata.Jul 12 2017, 2:52 PM

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

eric_metricspace.net added a comment.Jul 13 2017, 12:26 PM
In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Fine by me. I think Allan was planning to do away with all of these pre-built images at some point anyway.

emaste added a comment.Sep 11 2017, 3:53 PM
In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Note it's 800k right now (FAT_SIZE) not 512k. I agree this is rather suboptimal, but the FAT filesystem image is stored uncompressed in /boot and we don't want to bloat a standard install with a 50M image. It looks like good progress is being made on bsdinstall though so with any luck this will very shortly be a moot point.

Note that I ended up creating a version of this change after forgetting about this review - shall I commandeer and upload that?

sys/boot/efi/boot1/Makefile
122 ↗(On Diff #30290)

This is gone as of rS323436.

132 ↗(On Diff #30290)

I ended up writing a similar patch (I forgot about this one) and used xz -d
I also think -f is unnecessary here.

sys/boot/efi/boot1/generate-fat.sh
16

I would like to have room for 2 copies of the boot1.efi at least, to allow users to keep a backup etc.

How about 384k for now?

imp added inline comments.Sep 11 2017, 4:08 PM
sys/boot/efi/boot1/generate-fat.sh
16

Sure. I don't care since the installboot(8) script I'm working on will make all this stuff obsolete.

allanjude updated this revision to Diff 33001.Sep 13 2017, 4:25 AM

Resync

This revision now requires review to proceed.Sep 13 2017, 4:25 AM
Harbormaster completed remote builds in B11536: Diff 33001.Sep 13 2017, 4:25 AM
tsoome accepted this revision.Sep 13 2017, 7:09 AM
This revision is now accepted and ready to land.Sep 13 2017, 7:09 AM
emaste accepted this revision.Sep 13 2017, 1:21 PM
Closed by commit rS323554: Increase EFI boot file size frok 128k to 384k (authored by allanjude). · Explain WhySep 13 2017, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
efi/
boot1/
2 lines
65 lines
65 lines
64 lines
64 lines
2 lines

Diff 25399

View Options

sys/boot/efi/boot1/Makefile.fat

Loading...
View Options

sys/boot/efi/boot1/fat-amd64.tmpl.bz2.uu

Loading...
View Options

sys/boot/efi/boot1/fat-arm.tmpl.bz2.uu

Loading...
View Options

sys/boot/efi/boot1/fat-arm64.tmpl.bz2.uu

Loading...
View Options

sys/boot/efi/boot1/fat-i386.tmpl.bz2.uu

Loading...
View Options

sys/boot/efi/boot1/generate-fat.sh

Loading...