Increase EFI MSDOSFS image size to 512Kib

[allanjude]

Summary

This patch increases the size of the msdosfs image generated for EFI boot1 to 512Kib. This is a part of https://reviews.freebsd.org/D7589, and is necessary to fit the GELI EFI support, which increases the size of the boot1 program.

This patch is a component of https://reviews.freebsd.org/D7589.

Test Plan

This does not affect behavior at all. It merely causes a larger image to be generated.

[allanjude]

This is more of a project-wide question, hopefully @emaste or something can answer it:

Does it still make sense to uuencode binary files like this? SVN can handle binary files just fine.

[emaste]

Does it still make sense to uuencode binary files like this? SVN can handle binary files just fine.

I would prefer we stopped uuencoding binary files, and just committed them directly. As far as I'm concerned it's a carryover from the CVS days, and there is no concern with any of the VCSes relevant to us today (svn/git/p4/hg, or esoteric ones like ClearCase used by some downstream consumers).

[eric_metricspace.net]

Rebase to HEAD

[allanjude]

I am going to do the uuencode change as well.

[allanjude]

Switch from uuencoded bzip to raw xz

[eric_metricspace.net]

As long as the max size is increased, it should work with my downstream changes.

[imp]

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

[eric_metricspace.net]

In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Fine by me. I think Allan was planning to do away with all of these pre-built images at some point anyway.

[emaste]

In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Note it's 800k right now (FAT_SIZE) not 512k. I agree this is rather suboptimal, but the FAT filesystem image is stored uncompressed in /boot and we don't want to bloat a standard install with a 50M image. It looks like good progress is being made on bsdinstall though so with any luck this will very shortly be a moot point.

Note that I ended up creating a version of this change after forgetting about this review - shall I commandeer and upload that?

sys/boot/efi/boot1/Makefile

128–129

This is gone as of rS323436.

138

I ended up writing a similar patch (I forgot about this one) and used xz -d
I also think -f is unnecessary here.

sys/boot/efi/boot1/generate-fat.sh

17

I would like to have room for 2 copies of the boot1.efi at least, to allow users to keep a backup etc.

How about 384k for now?

[imp]

sys/boot/efi/boot1/generate-fat.sh

17

Sure. I don't care since the installboot(8) script I'm working on will make all this stuff obsolete.

[allanjude]

Resync