Page MenuHomeFreeBSD
Differential D7710

net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 30 2016, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 7:03 AM
Unknown Object (File)
Sun, Jan 12, 2:50 AM
Unknown Object (File)
Dec 16 2024, 12:37 PM
Unknown Object (File)
Dec 7 2024, 4:38 AM
Unknown Object (File)
Nov 30 2024, 1:26 AM
Unknown Object (File)
Nov 29 2024, 9:11 PM
Unknown Object (File)
Nov 19 2024, 8:12 PM
Unknown Object (File)
Nov 16 2024, 1:50 PM
View All 69 Files
Subscribers
ae
freebsd-net-list
• hselasky
imp
melifaro
zlei

Details

Reviewers
bms
• hselasky
glebius
araujo
gnn
bz
rwatson
Commits
rS305177: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19837.Aug 30 2016, 9:46 AM
sepherosa_gmail.com retitled this revision from to net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: glebius, bz, gnn, rwatson, araujo, bms.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
sepherosa_gmail.com added a comment.Aug 31 2016, 8:50 AM

I plan to commit this next Monday, if no objection comes.

araujo accepted this revision.Aug 31 2016, 8:53 AM
araujo edited edge metadata.

It looks good for me.
On Linux implementation it is also 13.

Best,

This revision is now accepted and ready to land.Aug 31 2016, 8:53 AM
• hselasky accepted this revision.Aug 31 2016, 9:12 AM
• hselasky added a reviewer: • hselasky.
• hselasky added a subscriber: • hselasky.

Don't forget to MFC.

Closed by commit rS305177: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1. (authored by sephe). · Explain WhySep 1 2016, 6:32 AM
This revision was automatically updated to reflect the committed changes.
zlei added a subscriber: zlei.Apr 11 2023, 7:15 AM
zlei added inline comments.
head/sys/net/ethernet.h
95 ↗(On Diff #19914)

pri is indeed shift with 13 bits. It is left shifted 1 bit and then 12 bits.
Beware the parentheses.

Left a comment in case someone reach this confusion.

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptApr 11 2023, 7:15 AM

Revision Contents
Changeset List

PathSize
sys/
net/
2 lines

Diff 19837

View Options

sys/net/ethernet.h

Loading...